Skip to content

chore: add translations for new setting#769

Merged
melzreal merged 1 commit intomasterfrom
melreal/add-translations-for-suggested-articles
Mar 16, 2026
Merged

chore: add translations for new setting#769
melzreal merged 1 commit intomasterfrom
melreal/add-translations-for-suggested-articles

Conversation

@melzreal
Copy link
Copy Markdown
Contributor

@melzreal melzreal commented Mar 6, 2026

Description

Add translations for new setting button, these need to go in first before the setting PR which will introduce screenshots for the labels as well.

Jira: https://zendesk.atlassian.net/jira/software/c/projects/GG/boards/8177?selectedIssue=GG-4392&visitedUserSeg=true

Screenshots

image

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@melzreal melzreal requested a review from a team as a code owner March 6, 2026 12:49
@melzreal melzreal force-pushed the melreal/add-translations-for-suggested-articles branch from 300bd78 to de1deec Compare March 6, 2026 13:07
@melzreal melzreal marked this pull request as draft March 6, 2026 13:08
@melzreal melzreal marked this pull request as ready for review March 6, 2026 13:08
@melzreal melzreal force-pushed the melreal/add-translations-for-suggested-articles branch from de1deec to e28dda6 Compare March 6, 2026 13:25
- translation:
key: "txt.help_center_copenhagen_theme.show_suggested_articles_label"
title: "Label for show suggested articles setting"
screenshot: ""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you are missing the screenshots on both.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the description:

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(essentially until the translations are in the pipeline they are not going to show)

- translation:
key: "txt.help_center_copenhagen_theme.show_suggested_articles_description"
title: "Description for the show suggested articles setting"
screenshot: ""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melzreal the screenshot is missing

Copy link
Copy Markdown
Contributor Author

@melzreal melzreal Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zendesk-mariannabuchicchio it doesnt have screenshots because the translations in the copenhagen theme need to be merged first in order for them to appear. So its not until it goes through the pipeline for translations that it will translate

(this is also mentioned in the description of the PR with the screenshot of what it looks like until they go through)

@zendesk-mariannabuchicchio zendesk-mariannabuchicchio added the g11n-approved Approved by Globalization label Mar 16, 2026
@melzreal melzreal merged commit 0276d5c into master Mar 16, 2026
8 checks passed
@melzreal melzreal deleted the melreal/add-translations-for-suggested-articles branch March 16, 2026 15:16
@zd-svc-github-copenhagen-theme
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 4.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

g11n-approved Approved by Globalization released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants