This repository was archived by the owner on Nov 23, 2024. It is now read-only.
Closed
Conversation
4eb3e3b to
1a9ce3b
Compare
Contributor
Author
|
I'm gonna start to maintain an own fork. If you still interest into this PR, contact me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
it's almost a rewrite of the shell script for helm script. I hope the new maintainer / well-known company @zendesk will have some time for this project.
I remove all bash related shell code and replace it with POSIX feature. The script will run on almost any posix compatible shell. The scripts is also compliant to shellcheck.
ZSH (MacOS default shell) and ash (Alpine default shell) should now out of the box supported. gnu-getops is not required anymore.
All tests from
test.share green under MacOS 10.15.4 (zsh, bash 3.2.57) and Alpine 3.11 (ash)Additional features:
All helm commands are supported now. Before this only
install|template|upgrade|lint|diffare supported. If plugins like kubeval are installed this script need to be modified. The PR remove the limitation.I recommend split view and ignore whitespaces for best experience to get all changes. https://github.com/zendesk/helm-secrets/pull/153/files?diff=split&w=1
Includes/Resolves/Fixes: