This repository was archived by the owner on Nov 23, 2024. It is now read-only.
Support yml extension and remove mandatory file pattern#155
Open
d-rk wants to merge 2 commits intozendesk:masterfrom
Open
Support yml extension and remove mandatory file pattern#155d-rk wants to merge 2 commits intozendesk:masterfrom
d-rk wants to merge 2 commits intozendesk:masterfrom
Conversation
|
any progress here? |
Author
Morriz
suggested changes
Sep 23, 2020
Morriz
left a comment
There was a problem hiding this comment.
I would suggest to cleanup the mixing of tabs and spaces, and only use two spaces (seeing that no specs are given in the repo).
|
I can do a more thorough review later and see if I have rights to approve and if that is enough to merge ;p |
Author
|
@Morriz the mixing of tabs and spaces was not introduced by this PR. This is also present on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi,
the restrictions on the secret names are very counter-intuitive. e.g.:
this fails, because
ymlis not supported. Additionally, the secret gets deleted with this :(Currently the secret has to conform the following regex:
^secrets(.[^.]+)*.yaml$
This pull request removes the restriction completely and allows any *.yml / *.yaml to be processed.
Instead of relying on the filename the content of the file is checked to verify that it is a sops encrypted file.
Resolves #124, resolves #128