This repository was archived by the owner on Nov 23, 2024. It is now read-only.
Allow customisable auth path for all other auth methods #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgokavarapuz
approved these changes
Apr 4, 2019
grosser
reviewed
Apr 4, 2019
grosser
reviewed
Apr 4, 2019
Author
|
I mean, the library isn't using keyword args anywhere else... |
|
does not hurt to start ... at least don't put optional arguments after options hash |
grosser
approved these changes
Apr 4, 2019
|
tests would be good ... but idk what the testing infrastructure looks like here 🤷♂️ |
Author
|
so ldap and tls options are completely untested in the integration tests, but added tests for the other ones. |
|
they all look very similar, can they get moved to a single generic auth method ? |
grosser
approved these changes
Apr 5, 2019
Author
|
:shurg: don't want to deal too much more with this gem right now. this does what i need. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of hashicorp#200 upstream.
/cc @zendesk/compute @zendesk/config