Skip to content

Update coaching impact to be additive instead of multiplicative #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-wang-1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update coaching impact to be additive instead of multiplicative #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/worker/core/player/developSeason.basketball.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ const ratingsFormulas: Record<Exclude<RatingKey, "hgt">, RatingFormula> = {

const calcBaseChange = (age: number, coachingRank: number): number => {
let val: number;
let variance: number;

if (age <= 21) {
val = 2;
Expand All @@ -189,24 +190,24 @@ const calcBaseChange = (age: number, coachingRank: number): number => {
val = -6;
}

// Noise
// Age based variance
if (age <= 23) {
val += helpers.bound(random.realGauss(0, 5), -4, 20);
variance = 20;
} else if (age <= 25) {
val += helpers.bound(random.realGauss(0, 5), -4, 10);
variance = 12;
} else {
val += helpers.bound(random.realGauss(0, 3), -2, 4);
variance = 8;
}

// Modulate by coaching. g.get("numActiveTeams") doesn't exist when upgrading DB, but that doesn't matter
if (Object.hasOwn(g, "numActiveTeams")) {
const numActiveTeams = g.get("numActiveTeams");
if (numActiveTeams > 1) {
if (val >= 0) {
val *= ((coachingRank - 1) * -0.5) / (numActiveTeams - 1) + 1.25;
} else {
val *= ((coachingRank - 1) * 0.5) / (numActiveTeams - 1) + 0.75;
}
// Vary base change by up to 25% of variance
val += (((coachingRank - 1) * -0.5) / (numActiveTeams - 1) + 0.25) * variance;
}
}

Expand Down