Skip to content

Enable build warnings #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable build warnings #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,57 @@ target_compile_definitions(
WIFI_NRF70_LOG_LEVEL=${CONFIG_WIFI_NRF70_LOG_LEVEL}
Copy link
Member

@jukkar jukkar Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about commit message. If we try to follow zephyr coding style, then we should probably set the commit subject to
build: Enable compiler warnings
or similar. Anyway, just a suggestion and not a hard requirement.

)

target_compile_options(nrf-wifi-osal PUBLIC
-Wall # All warnings
-Wextra # Extra warnings
-Werror # Warnings as errors
-Wformat=2 # Format string checks
-Wformat-security # Security issues with format strings
-Wnull-dereference # Null pointer dereferences
-Wstack-protector # Stack protection
-fstack-protector-strong # Strong stack protection
-Warray-bounds # Array bounds checking
-Wstringop-overflow # String operation overflow
-Wconversion # Implicit conversions
-Wsign-conversion # Sign conversions
-Wmissing-include-dirs # Missing include directories
-Wcast-align # Pointer cast alignment
-Wcast-qual # Pointer cast dropping qualifiers
-Wdiscarded-qualifiers # Discarded qualifiers
-Wduplicated-branches # Duplicated branches
-Wduplicated-cond # Duplicated conditions
-Wlogical-op # Suspicious logical operators
-Wnull-dereference # Null pointer dereferences
-Wjump-misses-init # Goto skipping variable initialization
-Wunused-parameter # Unused parameters
-Wshift-overflow=2 # Shift overflows
-Wmissing-prototypes # Missing function prototypes
-Wredundant-decls # Redundant declarations
-Wtype-limits # Type limits
-Wshadow # Shadowed variables
-Wstrict-prototypes # Strict prototypes
-Wundef # Undefined macros
-Wuninitialized # Uninitialized variables
-Wpointer-arith # Pointer arithmetic
-Wbad-function-cast # Bad function casts
-Wstrict-overflow # Strict overflow
-Winline # Inlining issues
-Wnested-externs # Nested externs
-Wold-style-definition # Old-style definitions
-Wmissing-declarations # Missing declarations
-Wmissing-noreturn # Missing noreturn
-Wdisabled-optimization # Disabled optimizations
-Wfloat-equal # Floating point equality
-Winit-self # Initialization to self
-Wswitch-default # Missing switch default
-Wswitch-enum # Missing switch enum
-Wunsafe-loop-optimizations # Unsafe loop optimizations
-Wlogical-not-parentheses # Logical not parentheses
-Wstrict-aliasing # Strict aliasing
-Wvariadic-macros # Variadic macros
-Wvolatile-register-var # Volatile register variables
)

target_include_directories(
nrf-wifi-osal
PUBLIC
Expand Down