Fix typo

[nerwalt]

keepalive_period changed to keep_alive_period

Discovered this while working on nrf70-bm with enhanced logging. This fix should therefore be propagated downstream.

[krish2718]

Though not strictly English it's common to use "keepalive" and that too this is just a variable not in the docs, so, we don't need this fix.

[nerwalt]

It needs to be fixed, as it results in a compilation error when debug-level logging is enabled. That is how I found it. I am working with the nrf70-bm driver, which depends onnrf_wifi. umac_cmd_data->keepalive_period does not exist. Please look at the preceding line. I fixed it locally and submitted this PR to address it upstream.

[krish2718]

It needs to be fixed, as it results in a compilation error when debug-level logging is enabled. That is how I found it. I am working with the nrf70-bm driver, which depends onnrf_wifi. umac_cmd_data->keepalive_period does not exist. Please look at the preceding line. I fixed it locally and submitted this PR to address it upstream.

Sorry, didn't realize it's fixing a build error, please update commit log to reflect his. You need to fix it other places too

diff --git a/fw_if/umac_if/src/offload_raw_tx/fmac_cmd.c b/fw_if/umac_if/src/offload_raw_tx/fmac_cmd.c
index 6f1b8f72a..aad80c79f 100644
--- a/fw_if/umac_if/src/offload_raw_tx/fmac_cmd.c
+++ b/fw_if/umac_if/src/offload_raw_tx/fmac_cmd.c
@@ -89,7 +89,7 @@ enum nrf_wifi_status umac_cmd_off_raw_tx_init(struct nrf_wifi_fmac_dev_ctx *fmac
        umac_cmd_data->keep_alive_enable = KEEP_ALIVE_ENABLED;
        umac_cmd_data->keep_alive_period = NRF_WIFI_KEEPALIVE_PERIOD_S;
        nrf_wifi_osal_log_dbg("Keepalive enabled with period %d",
-                                  umac_cmd_data->keepalive_period);
+                                  umac_cmd_data->keep_alive_period);
 #endif /* NRF_WIFI_FEAT_KEEPALIVE */
 
        umac_cmd_data->op_band = op_band;
diff --git a/fw_if/umac_if/src/radio_test/fmac_cmd.c b/fw_if/umac_if/src/radio_test/fmac_cmd.c
index e247d427f..612c500a3 100644
--- a/fw_if/umac_if/src/radio_test/fmac_cmd.c
+++ b/fw_if/umac_if/src/radio_test/fmac_cmd.c
@@ -89,7 +89,7 @@ enum nrf_wifi_status umac_cmd_rt_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ctx
        umac_cmd_data->keep_alive_enable = KEEP_ALIVE_ENABLED;
        umac_cmd_data->keep_alive_period = NRF_WIFI_KEEPALIVE_PERIOD_S;
        nrf_wifi_osal_log_dbg("Keepalive enabled with period %d",
-                                  umac_cmd_data->keepalive_period);
+                                  umac_cmd_data->keep_alive_period);
 #endif /* NRF_WIFI_FEAT_KEEPALIVE */
 
        umac_cmd_data->op_band = op_band;
diff --git a/fw_if/umac_if/src/system/fmac_cmd.c b/fw_if/umac_if/src/system/fmac_cmd.c
index 4f0b588c1..4848aee1f 100644
--- a/fw_if/umac_if/src/system/fmac_cmd.c
+++ b/fw_if/umac_if/src/system/fmac_cmd.c
@@ -95,7 +95,7 @@ enum nrf_wifi_status umac_cmd_sys_init(struct nrf_wifi_fmac_dev_ctx *fmac_dev_ct
        umac_cmd_data->keep_alive_enable = KEEP_ALIVE_ENABLED;
        umac_cmd_data->keep_alive_period = NRF_WIFI_KEEPALIVE_PERIOD_S;
        nrf_wifi_osal_log_dbg("Keepalive enabled with period %d",
-                                  umac_cmd_data->keepalive_period);
+                                  umac_cmd_data->keep_alive_period);
 #endif /* NRF_WIFI_FEAT_KEEPALIVE */
 
        nrf_wifi_osal_mem_cpy(umac_cmd_data->rx_buf_pools,

[nerwalt]

Updated

[krish2718]

Updated

Please raise a PR in https://github.com/zephyrproject-rtos/zephyr/ to update the manifest (that also triggers CI).

[krish2718]

Discovered this while working on nrf70-bm with enhanced logging. This fix should therefore be propagated downstream.

You can raise a PR to https://github.com/zephyrproject-rtos/nrf_wifi/tree/nrf70_bm_branch and a manifest update PR to https://github.com/nrfconnect/nrf70-bm (both west and git submodule)