drivers: dma: mspm0: DMA driver support #91502
Conversation
|
drivers/dma/dma_mspm0.c
Outdated
|
|
||
| struct dma_mspm0_channel_data { | ||
| uint8_t direction; | ||
| bool busy; |
There was a problem hiding this comment.
move these 2 at the end for better alignment
karthi012
force-pushed
the
upstream/ti/mspm0-dma
branch
from
1109426 to
1778ccb
Compare
zephyrbot
added
area: DMA
|
karthi012
force-pushed
the
upstream/ti/mspm0-dma
branch
from
1778ccb to
c412d28
Compare
|
@teburd @vaishnavachath @tbursztyka Ping for review |
drivers/dma/dma_ti_mspm0.c
Outdated
| break; | ||
| default: | ||
| return -EINVAL; | ||
| } |
There was a problem hiding this comment.
Some funky formatting here needs to be fixed.
I recommend trying to use clang-format on the file to make it easier now and in the future to make changes. Disabling formatting for certain macros and such is just fine. If it doesn't work it doesn't work, but worth a go.
drivers/dma/dma_ti_mspm0.c
Outdated
| return -EINVAL; | ||
| } | ||
|
|
||
| dma_cfg.destWidth = temp; |
There was a problem hiding this comment.
Some formatting issues here
Add DMA driver binding for Texas Instruments MSPM0 Family Series Signed-off-by: Karthikeyan Krishnasamy <[email protected]>
Add DMA driver support for Texas Instruments MSPM0 Family Series. Signed-off-by: Karthikeyan Krishnasamy <[email protected]>
Add DMA controller support for Texas Instruments MSPM0 Family of SoCs. Signed-off-by: Karthikeyan Krishnasamy <[email protected]>
karthi012
force-pushed
the
upstream/ti/mspm0-dma
branch
from
c412d28 to
6bdf294
Compare
|
| dma_cfg.triggerType = DL_DMA_TRIGGER_TYPE_EXTERNAL; | ||
| dma_cfg.trigger = config->dma_slot; | ||
|
|
||
| DL_DMA_clearInterruptStatus(DMA, channel + DMA_TI_MSPM0_BASE_CHANNEL_NUM); |
There was a problem hiding this comment.
It's unclear here if there are any shared registers, but if any register is shared the register update needs to be done inside a spin lock (critical section)
Add DMA driver support for Texas Instruments MSPM0 Family Series