Enabling DMA Support for frdm_mcxw7x #91869
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: NXP Drivers
github-actions
bot
requested review from
bperseghetti,
butok,
dbaluta,
decsny,
DerekSnell,
dleach02,
George-Stefan,
manuargue,
MaochenWang1,
mmahadevan108,
nordic-krch,
PetervdPerk-NXP,
Raymond0225 and
teburd
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_dma
branch
3 times, most recently
from
7043218 to
8fb1415
Compare
|
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_dma
branch
from
8fb1415 to
22d8690
Compare
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_dma
branch
2 times, most recently
from
90c083d to
2cdd5f9
Compare
|
re-assigned to platform owner, no changes to DMA API in PR, all soc, dts, and driver changes from what I can tell. |
There was a problem hiding this comment.
Pull Request Overview
Enables DMA support for the frdm_mcxw7x family of boards by implementing EDMA v3 controller support and adding necessary board configurations.
- Adds EDMA device tree node to nxp_mcxw7x_common.dtsi with DMA channel and request configurations
- Enables DMA support in board YAML files and device tree overlays for frdm_mcxw71 and frdm_mcxw72
- Implements EDMA v3-specific configuration and handling in the DMA driver, including memory-to-memory transfer support without DMAMUX
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| dts/arm/nxp/nxp_mcxw7x_common.dtsi | Adds EDMA controller node and DMA properties to UART nodes |
| boards/nxp/frdm_mcxw72/frdm_mcxw72_mcxw727c_cpu0.yaml | Adds DMA to supported features list |
| boards/nxp/frdm_mcxw72/frdm_mcxw72_mcxw727c_cpu0.dts | Enables EDMA controller |
| boards/nxp/frdm_mcxw71/frdm_mcxw71.yaml | Adds DMA to supported features list |
| boards/nxp/frdm_mcxw71/frdm_mcxw71.dts | Enables EDMA controller |
| soc/nxp/mcx/mcxw/soc.c | Adds clock initialization for DMA controller |
| drivers/dma/dma_mcux_edma.c | Refactors driver to support EDMA v3 without DMAMUX |
| include/zephyr/dt-bindings/clock/scg_k4.h | Adds EDMA clock definition |
| modules/hal_nxp/mcux/mcux-sdk-ng/drivers/drivers.cmake | Updates build configuration for MCXW family |
| tests/drivers/dma/loop_transfer/boards/ | Adds test overlay files for new boards |
| tests/drivers/uart/uart_async_api/testcase.yaml | Adds test configuration for frdm_mcxw72 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
decsny
force-pushed
the
feature/frdm_mcxw7x_dma
branch
from
5c5ad8a to
0a764df
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
decsny
force-pushed
the
feature/frdm_mcxw7x_dma
branch
from
0a764df to
39657dc
Compare
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_dma
branch
from
39657dc to
dd15029
Compare
|
decsny
previously approved these changes
Aug 29, 2025
|
tests/drivers/uart/uart_async_api/drivers.uart.async_api.lpuart test failure which is OK in mainline. and
|
|
@EmilioCBen please address Hakes issue |
1 task
I am not seeing these build failures, with |
Split this function up even more Signed-off-by: Declan Snyder <[email protected]>
Support EDMAv3 platform that do not have dmamux or always on capability. Therefore, memory to memory transfer is limited in this environment. Signed-off-by: Declan Snyder <[email protected]> Co-authored-by: Emilio Benavente <[email protected]>
Add DMA nodes for MCXW7X SOC DTS. This SOC used TRIGMUX instead of DMAMUX. Enable EDMAv3 for the frdm_mcxw71 and frdm_mcxw72 platforms. Signed-off-by: Emilio Benavente <[email protected]> Co-authored-by: Declan Snyder <[email protected]>
decsny
force-pushed
the
feature/frdm_mcxw7x_dma
branch
from
dd15029 to
e243beb
Compare
|
rebased, fixed conflict, added mcxw71 overlay to test @hakehuang i cannot get uart async test to pass on main with other platform mcxa153, so I am thinking there is something wrong with the uart driver or test, are you able to get any lpuart platform on main passing ? |
zephyrbot
added
area: Boards/SoCs
area: Devicetree Bindings
area: Tests
|
below is the failure platform. rt5/6xx is due to the mpu region issues, frdm_ke17z512 and lpc55 series are due to board design issue. I send you the full report.
|
hakehuang
reviewed
Sep 30, 2025
| - platform:frdm_mcxn236/mcxn236:"DTC_OVERLAY_FILE=nxp/dut_flexcomm2_lpuart2.overlay" | ||
| - platform:frdm_mcxn947/mcxn947/cpu0:"DTC_OVERLAY_FILE=nxp/dut_flexcomm2_lpuart2.overlay" | ||
| - platform:frdm_mcxn947/mcxn947/cpu0/qspi:"DTC_OVERLAY_FILE=nxp/dut_flexcomm2_lpuart2.overlay" | ||
| - platform:frdm_mcxw72/mcxw727c/cpu0:"DTC_OVERLAY_FILE=nxp/dut_lpuart1.overlay" |
There was a problem hiding this comment.
I would recommend to add dut_lpuart0_loopback.overlay, change from ut_lpuart0_loopback.overlay, as lpuart ip has a internal loopback. no need to fly wire. and in frdm_mcxw72, lpuart1 is reused with can and used by mculink as uart interface.
hakehuang
reviewed
Sep 30, 2025
| - platform:frdm_mcxn947/mcxn947/cpu0:"DTC_OVERLAY_FILE=nxp/dut_flexcomm2_lpuart2.overlay" | ||
| - platform:frdm_mcxn947/mcxn947/cpu0/qspi:"DTC_OVERLAY_FILE=nxp/dut_flexcomm2_lpuart2.overlay" | ||
| - platform:frdm_mcxw72/mcxw727c/cpu0:"DTC_OVERLAY_FILE=nxp/dut_lpuart1.overlay" | ||
| - platform:frdm_mcxw71/mcxw716c:"DTC_OVERLAY_FILE=nxp/dut_lpuart1.overlay" |
There was a problem hiding this comment.
for frdm_mcxw71 we can not use lpuart1, as this is used as default uart, we need use lpuart0 with loopback mode
dut_lpuart0_loopback.overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling DMA Support for frdm_mcxw7x