Adding flexio pwm support for MCXW71 and MCXW72 devices. #92325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Clock Control
platform: NXP Drivers
github-actions
bot
requested review from
anangl,
butok,
dbaluta,
DerekSnell,
dleach02,
George-Stefan,
henrikbrixandersen,
manuargue,
MaochenWang1,
mmahadevan108,
nordic-krch and
Raymond0225
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nxp
DNM (manifest)
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
2 times, most recently
from
c01b24e to
ab33dcc
Compare
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
from
ab33dcc to
5a2c34b
Compare
github-actions
bot
removed
the
DNM (manifest)
mmahadevan108
previously approved these changes
Jul 23, 2025
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
2 times, most recently
from
9c56472 to
e8d7c82
Compare
mmahadevan108
previously approved these changes
Jul 23, 2025
|
@EmilioCBen please fix the merge conflict. |
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
from
e8d7c82 to
1d46661
Compare
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
from
1d46661 to
353cb3f
Compare
dleach02
reviewed
Jul 25, 2025
drivers/pwm/pwm_nxp_flexio.c
Outdated
| is_only_low_or_high = true; | ||
| } else if (duty_cycle == period_cycles && !pulse_cycles) { | ||
| polarity = FLEXIO_PWM_ACTIVE_HIGH; | ||
| is_only_low_or_high = true; | ||
| } |
There was a problem hiding this comment.
@EmilioCBen the SonarCube is flagging this because it wants an empty "else" here for defensive programming reasons. So end this with:
} else {
/* Some reasonable comment on why there isn't anything in the else block */
}
There was a problem hiding this comment.
Updated the code, just hoping an empty else case doesn't get flagged.
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
2 times, most recently
from
3768a7e to
5bdc35b
Compare
mmahadevan108
previously approved these changes
Jul 28, 2025
decsny
reviewed
Jul 28, 2025
drivers/pwm/pwm_nxp_flexio.c
Outdated
| if (period_cycles == pulse_cycles) { | ||
| polarity = FLEXIO_PWM_ACTIVE_LOW; | ||
| is_only_low_or_high = true; | ||
| } else if (duty_cycle == period_cycles && !pulse_cycles) { |
There was a problem hiding this comment.
!pulse_cycles should be pulse_cycles == 0
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
from
5bdc35b to
57c6836
Compare
dleach02
previously approved these changes
Aug 1, 2025
decsny
requested changes
Aug 4, 2025
Updated the nxp flexio pwm driver to account for when the duty cycle is 100% or 0%. We switch off the counter of the flexio and manually set the GPIO High or Low. Otherwise Flexio Peripheral with default to a 50% duty cycle behavior. Factored out timerOutput variable. Signed-off-by: Emilio Benavente <[email protected]>
Updated the nxp_mcxw7x dts to include a flexio_pwm node. Signed-off-by: Emilio Benavente <[email protected]>
Enabled testing for the flexio pwm on MCXW7X Platforms. Signed-off-by: Emilio Benavente <[email protected]>
EmilioCBen
force-pushed
the
feature/frdm_mcxw7x_flexio_pwm
branch
from
57c6836 to
0f62dc5
Compare
|
decsny
approved these changes
Aug 6, 2025
dleach02
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding flexio pwm support for MCXW71 and MCXW72 devices.