sensor: Add ICM42686 Driver Support #92579
Open
+1,700
−1,448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubieda
force-pushed
the
feature/icm42686-driver-support
branch
5 times, most recently
from
0f64e78 to
7477da4
Compare
|
Looks like the issues flagged by SonarQube are due to moving existing in-tree files. I wonder if we're good with addressing them on follow-up PRs instead of blocking this one. |
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
afontaine-invn,
asemjonovs,
avisconti,
bperseghetti,
danieldegrasse,
gjabouley-invn,
jeppenodgaard,
manuargue,
MaureenHelm,
PetervdPerk-NXP,
rbuisson-invn,
sriccardi-invn,
teburd,
tristan-google and
yperess
bperseghetti
previously approved these changes
Jul 4, 2025
teburd
previously approved these changes
Jul 4, 2025
PetervdPerk-NXP
previously approved these changes
Jul 7, 2025
afontaine-invn
previously approved these changes
Jul 8, 2025
As a first step to enable the similar variants (e.g: ICM42686), refactor common functionality into icm4268x files. As a result, applications using the icm42688 will need to have both compatible properties: "invensense,icm42688" and "invensense,icm4268x" defined. In-tree boards have been modified to comply with this pattern. This patch does not contain functional changes. The driver should work the same as before. Signed-off-by: Luis Ubieda <[email protected]>
Addressing low-hanging fruits. Put in a separate commit in order to make it easier to keep track of changes. Signed-off-by: Luis Ubieda <[email protected]>
Now this driver supports both ICM42688 and ICM42686. Tested with read-decode as well as streaming mode. Signed-off-by: Luis Ubieda <[email protected]>
Additionally, remove overlay from sensor-shell sample, which is redundant. Signed-off-by: Luis Ubieda <[email protected]>
For build-time validation. Signed-off-by: Luis Ubieda <[email protected]>
Users now requiring to define both dt compatibles: both icm4268x and icm42688 to work. Signed-off-by: Luis Ubieda <[email protected]>
ubieda
dismissed stale reviews from afontaine-invn, PetervdPerk-NXP, teburd, and bperseghetti
via
f135b0c
ubieda
force-pushed
the
feature/icm42686-driver-support
branch
from
7477da4 to
f135b0c
Compare
|
|
I just rebased to resolve the conflicts and move the migration guide to 4.3.0. WRT SonarQube issues: I gave another pass at the issues pointed out, and they're now reduced to two types:
After this round, I've repeated the test-verification listed in the PR description and I've got the same results. I'll stick around to see all CI checks pass, then I'll stand by for another round of reviews. |
ubieda
requested review from
teburd,
afontaine-invn,
bperseghetti and
PetervdPerk-NXP
bperseghetti
approved these changes
Jul 23, 2025
afontaine-invn
approved these changes
Jul 24, 2025
teburd
approved these changes
Jul 24, 2025
| zephyr_library_sources_ifdef(CONFIG_SENSOR_ASYNC_API icm4268x_rtio.c) | ||
| zephyr_library_sources_ifdef(CONFIG_ICM4268X_DECODER icm4268x_decoder.c) | ||
| zephyr_library_sources_ifdef(CONFIG_ICM4268X_STREAM icm4268x_rtio_stream.c) | ||
| zephyr_library_sources_ifdef(CONFIG_ICM4268X_TRIGGER icm4268x_trigger.c) |
There was a problem hiding this comment.
Of all the APIs the Sensor API has currently, I believe the trigger API is the least usable among them and conflicts the most with the stream API. I'm wondering if perhaps this API is one we really should aim to deprecate.
Supporting the polling read and stream is fairly easy I think. Supporting trigger and stream seems conflict ridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for ICM42686 driver, by extending and refactoring existing ICM42688 driver.
The new variant contains feature parity with the original driver:
Testing
This was tested on VMU RT1170, which contains both ICM42688 and ICM42686, running the sensor-shell sample to set up and obtain sensor readings: