DSA tag protocol support #93010

yangbolu1991 · 2025-07-11T09:44:52Z

This PR is to support DSA tag protocol in DSA core driver. Also added NXP NETC tag protocol driver, and enabled on NXP i.MX943 as an example to verify.

There is a hal dependency: zephyrproject-rtos/hal_nxp#575
Thanks a lot.

Attached dsa sample log.

[00:00:00.056,000] <inf> phy_mii: PHY (2) ID 20005CA2
[00:00:00.107,000] <inf> phy_mii: PHY (3) ID 20005CA2
[00:00:00.144,000] <inf> dsa_netc: DSA user port 0 Link down
[00:00:00.145,000] <inf> dsa_netc: DSA user port 1 Link down
[00:00:00.145,000] <inf> nxp_imx_eth_psi: ENETC3 MAC: 00:04:9f:00:11:00
*** Booting Zephyr OS build v4.2.0-rc2-120-gb0fc94da3d01 ***
[00:00:00.155,000] <inf> net_dsa_sample: [0] User interface 1 found.
[00:00:00.155,000] <inf> net_dsa_sample: [1] User interface 2 found.
[00:00:00.155,000] <inf> net_dsa_sample: DSA ports init - OK
[00:00:02.214,000] <inf> phy_mii: PHY (3) Link speed 100 Mb, full duplex
[00:00:02.214,000] <inf> dsa_netc: DSA user port 1 Link up
[00:00:02.214,000] <inf> net_dsa_sample: Port 2 is up
uart:~$
uart:~$
[00:00:10.174,000] <inf> net_dhcpv4: Received: 10.193.20.37
uart:~$
uart:~$
uart:~$
uart:~$ net ping 10.193.20.164
PING 10.193.20.164
28 bytes from 10.193.20.164 to 10.193.20.37: icmp_seq=1 ttl=64 time=0 ms
28 bytes from 10.193.20.164 to 10.193.20.37: icmp_seq=2 ttl=64 time=0 ms
28 bytes from 10.193.20.164 to 10.193.20.37: icmp_seq=3 ttl=64 time=0 ms
[00:00:23.722,000] <inf> phy_mii: PHY (3) is down
[00:00:23.722,000] <inf> dsa_netc: DSA user port 1 Link down
[00:00:28.163,000] <inf> phy_mii: PHY (2) Link speed 100 Mb, full duplex
[00:00:28.163,000] <inf> dsa_netc: DSA user port 0 Link up
[00:00:28.163,000] <inf> net_dsa_sample: Port 1 is up
uart:~$
uart:~$
uart:~$
[00:00:34.122,000] <inf> net_dhcpv4: Received: 10.193.20.163
uart:~$ net ping 10.193.20.164
PING 10.193.20.164
28 bytes from 10.193.20.164 to 10.193.20.163: icmp_seq=1 ttl=64 time=1 ms
28 bytes from 10.193.20.164 to 10.193.20.163: icmp_seq=2 ttl=64 time=0 ms
28 bytes from 10.193.20.164 to 10.193.20.163: icmp_seq=3 ttl=64 time=0 ms
uart:~$

github-actions · 2025-07-11T09:46:16Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`19c05e1`	zephyrproject-rtos/hal_nxp#575	zephyrproject-rtos/hal_nxp#575/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

yangbolu1991 · 2025-07-15T08:50:06Z

Updated to fix twister issues.
Thanks.

include/zephyr/net/dsa_core.h

subsys/net/l2/ethernet/dsa/Kconfig

subsys/net/l2/ethernet/dsa/dsa_tag.c

drivers/ethernet/dsa/dsa_nxp_imx_netc.c

include/zephyr/net/dsa_core.h

subsys/net/l2/ethernet/dsa/dsa_tag.h

subsys/net/l2/ethernet/dsa/dsa_tag_netc.h

yangbolu1991 · 2025-07-28T04:12:58Z

Updated to v3. Changes include,

Code improvement per @pdgendt suggestion.

Thanks.

yangbolu1991 · 2025-07-28T04:19:32Z

Rebased to address west.yml conflict.
Thanks.

yangbolu1991 · 2025-07-30T03:10:51Z

Rebased to address conflict.
Thanks.

subsys/net/l2/ethernet/dsa/dsa_tag_netc.c

Updated hal_nxp to support netc tag driver. Signed-off-by: Yangbo Lu <[email protected]>

Moved DSA core options to subsystem. Signed-off-by: Yangbo Lu <[email protected]>

Moved NXP NETC DSA driver to dsa directory. Signed-off-by: Yangbo Lu <[email protected]>

Added tag protocol definition and binding. Also introduced zephyr,dsa-port compatible for future tag protocol driver Kconfig dependency checking. Updated existed dts. Signed-off-by: Yangbo Lu <[email protected]>

Added NXP NETC tag protocol driver. Signed-off-by: Yangbo Lu <[email protected]>

Supported tag protocol setup. Signed-off-by: Yangbo Lu <[email protected]>

Allowed to transmit DSA tag frame. Signed-off-by: Yangbo Lu <[email protected]>

Added tag protocol support. Signed-off-by: Yangbo Lu <[email protected]>

Added NETC switch node. Signed-off-by: Yangbo Lu <[email protected]>

Added NETC switch support for M33. Signed-off-by: Yangbo Lu <[email protected]>

Added imx943_evk_mimx94398_m33_ddr board support. Signed-off-by: Yangbo Lu <[email protected]>

Added NETC switch support for M33 in doc. Signed-off-by: Yangbo Lu <[email protected]>

yangbolu1991 · 2025-08-01T05:16:36Z

Updated to v4. Changes include,

Addressed conflict.
Avoided data copying during netc tag header inserting.

Thanks.

yangbolu1991 · 2025-08-01T05:20:34Z

@jukkar Could you help to review the PR when you get any chance?
Thanks a lot.

i.MX943 M33 supports multi-level interrupt with NUM_IRQS 405. Current ram_context_for_isr test does not cover multi-level interrupt. So exclude i.MX943 M33. Signed-off-by: Yangbo Lu <[email protected]>

yangbolu1991 · 2025-08-01T09:55:47Z

It seems code base introduced a new test case which didn't apply to i.MX943 M33, causing twister issues.
So, added one more patch to exclude i.MX943 M33 to fix twister issues.

Thanks.

sonarqubecloud · 2025-08-01T10:19:18Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions bot added area: Samples Samples area: Ethernet area: Networking platform: NXP Drivers NXP Semiconductors, drivers platform: NXP MPU area: Devicetree labels Jul 11, 2025

github-actions bot requested review from clamattia, dbaluta, decsny, dleach02, iuliana-prodan, JiafeiPan, jukkar, lmajewski, maass-hamburg, manuargue, mmahadevan108, pdgendt, Raymond0225, rlubos and ssharks July 11, 2025 09:46

github-actions bot assigned rlubos and jukkar Jul 11, 2025

github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 11, 2025

yangbolu1991 force-pushed the dsa-tag-support branch from 8eeddfa to 5a91672 Compare July 15, 2025 08:49

JiafeiPan reviewed Jul 22, 2025

View reviewed changes

yangbolu1991 force-pushed the dsa-tag-support branch from e324a49 to 8977cf0 Compare July 28, 2025 04:12

yangbolu1991 force-pushed the dsa-tag-support branch from 8977cf0 to 29d291e Compare July 28, 2025 04:18

yangbolu1991 force-pushed the dsa-tag-support branch from 29d291e to 2b3c9a3 Compare July 30, 2025 03:10

JiafeiPan previously approved these changes Jul 31, 2025

View reviewed changes

subsys/net/l2/ethernet/dsa/dsa_tag_netc.c Outdated Show resolved Hide resolved

yangbolu1991 added 12 commits August 1, 2025 12:43

west.yml: update hal_nxp to support netc tag driver

31f8e0c

Updated hal_nxp to support netc tag driver. Signed-off-by: Yangbo Lu <[email protected]>

net: dsa: move DSA core options to subsystem

cc74b7d

Moved DSA core options to subsystem. Signed-off-by: Yangbo Lu <[email protected]>

drivers: ethernet: move NXP NETC DSA driver to dsa directory

30ebb77

Moved NXP NETC DSA driver to dsa directory. Signed-off-by: Yangbo Lu <[email protected]>

net: dsa: add tag protocol definition and binding

4cd4d09

Added tag protocol definition and binding. Also introduced zephyr,dsa-port compatible for future tag protocol driver Kconfig dependency checking. Updated existed dts. Signed-off-by: Yangbo Lu <[email protected]>

net: dsa: add NXP NETC tag protocol driver

9d3a9f7

Added NXP NETC tag protocol driver. Signed-off-by: Yangbo Lu <[email protected]>

net: dsa: support tag protocol setup

dcc3956

Supported tag protocol setup. Signed-off-by: Yangbo Lu <[email protected]>

drivers: eth_nxp_imx_netc: allow to transmit DSA tag frame

26d08f8

Allowed to transmit DSA tag frame. Signed-off-by: Yangbo Lu <[email protected]>

drivers: dsa_nxp_imx_netc: add tag protocol support

ca148e0

Added tag protocol support. Signed-off-by: Yangbo Lu <[email protected]>

dts: arm: nxp_imx943_m33: add NETC switch node

2b9e56c

Added NETC switch node. Signed-off-by: Yangbo Lu <[email protected]>

boards: nxp: imx943_evk: add NETC switch support for M33

b2bcd23

Added NETC switch support for M33. Signed-off-by: Yangbo Lu <[email protected]>

samples: net: dsa: add imx943_evk_mimx94398_m33_ddr board support

f6783cd

Added imx943_evk_mimx94398_m33_ddr board support. Signed-off-by: Yangbo Lu <[email protected]>

boards: nxp: imx943_evk: doc update for NETC switch support for M33

75b8e62

Added NETC switch support for M33 in doc. Signed-off-by: Yangbo Lu <[email protected]>

yangbolu1991 dismissed JiafeiPan’s stale review via 75b8e62 August 1, 2025 05:15

yangbolu1991 force-pushed the dsa-tag-support branch from 2b3c9a3 to 75b8e62 Compare August 1, 2025 05:15

yangbolu1991 requested review from pdgendt and JiafeiPan August 1, 2025 05:19

test: ram_context_for_isr: exclude imx943 m33

ba48443

i.MX943 M33 supports multi-level interrupt with NUM_IRQS 405. Current ram_context_for_isr test does not cover multi-level interrupt. So exclude i.MX943 M33. Signed-off-by: Yangbo Lu <[email protected]>

zephyrbot added the area: Build System label Aug 1, 2025

JiafeiPan approved these changes Aug 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DSA tag protocol support #93010

DSA tag protocol support #93010

Uh oh!

yangbolu1991 commented Jul 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

yangbolu1991 commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yangbolu1991 commented Jul 28, 2025

Uh oh!

yangbolu1991 commented Jul 28, 2025

Uh oh!

yangbolu1991 commented Jul 30, 2025

Uh oh!

Uh oh!

yangbolu1991 commented Aug 1, 2025

Uh oh!

yangbolu1991 commented Aug 1, 2025

Uh oh!

yangbolu1991 commented Aug 1, 2025

Uh oh!

sonarqubecloud bot commented Aug 1, 2025

Uh oh!

Uh oh!

DSA tag protocol support #93010

Are you sure you want to change the base?

DSA tag protocol support #93010

Uh oh!

Conversation

yangbolu1991 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yangbolu1991 commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yangbolu1991 commented Jul 28, 2025

Uh oh!

yangbolu1991 commented Jul 28, 2025

Uh oh!

yangbolu1991 commented Jul 30, 2025

Uh oh!

Uh oh!

yangbolu1991 commented Aug 1, 2025

Uh oh!

yangbolu1991 commented Aug 1, 2025

Uh oh!

yangbolu1991 commented Aug 1, 2025

Uh oh!

sonarqubecloud bot commented Aug 1, 2025

Quality Gate passed

Uh oh!

Uh oh!

yangbolu1991 commented Jul 11, 2025 •

edited

Loading

github-actions bot commented Jul 11, 2025 •

edited

Loading