dts/boards: nordic: Fix some reg issues #93098
Conversation
nordicjm
commented
Jul 14, 2025
nordicjm
commented
Adds missing reg parameters to DTS nodes Signed-off-by: Jamie McCrae <[email protected]>
This compatible does not exist Signed-off-by: Jamie McCrae <[email protected]>
Fixes the address of this peripheral Signed-off-by: Jamie McCrae <[email protected]>
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
|
|
||
| mx25uw63: mx25uw6345g@0 { | ||
| compatible = "mxicy,mx25u", "jedec,mspi-nor"; | ||
| compatible = "jedec,mspi-nor"; |
There was a problem hiding this comment.
The compatible needs to stay, quirks in mspi_nor driver depend on it.
There was a problem hiding this comment.
then a compatible binding needs to be created
There was a problem hiding this comment.
and actually that isn't even right, it should be doing what the spi_nor driver does with flags: https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/mtd/jedec%2Cspi-nor-common.yaml#L93
There was a problem hiding this comment.
Opened an issue about this: #93135
There was a problem hiding this comment.
Any update on this please?
Removes compatible strings that were not defined and are not needed Signed-off-by: Jamie McCrae <[email protected]>
|
There was a problem hiding this comment.
My approval implies that the changes requested by the vscode team were done. But we do not have scope and knowledge to determine any side effects. Please make sure someone who knows how these files are used in the SDK by apps and customers; also reviews these changes
|
@nordicjm should we close this now? |
|
mx25 parts moved to #96701 |
