boards: Add support for PG23/PG28 Pro Kit #93285

janchri · 2025-07-17T20:24:58Z

This PR adds support for two development kits from Silicon Labs:

xG23-PK2504A
xG28-PK2506A

For the xG23-PK2504A, RTT has been configured due to issues when accessing the console via EUSART0/1. Tested manually on basic samples (hello world, blinky, and button).

This PR builds on the work carried out for xg24_ek2703a and other ports from the dev Kit folder.

Depends on: zephyrproject-rtos/hal_silabs#95

github-actions · 2025-07-17T20:25:38Z

Hello @janchri, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions · 2025-07-17T20:26:25Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_silabs	zephyrproject-rtos/hal_silabs@`190a144`	zephyrproject-rtos/hal_silabs#95	zephyrproject-rtos/hal_silabs#95/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a-pinctrl.dtsi

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a_defconfig

boards/silabs/dev_kits/xg28_pk2506a/xg28_pk2506a_defconfig

soc/silabs/silabs_s2/efm32pg23/Kconfig

asmellby · 2025-07-21T08:08:27Z

boards/silabs/dev_kits/xg23_pk2504a/Kconfig.defconfig

+	default 875000
+	depends on LOG_BACKEND_SWO
+
+if SOC_GECKO_USE_RAIL


This if block for RAIL isn't needed on PG23, since it doesn't have a radio.

asmellby · 2025-07-21T08:09:11Z

boards/silabs/dev_kits/xg23_pk2504a/board.yml

@@ -0,0 +1,6 @@
+board:
+  name: xg23_pk2504a
+  full_name: PG28 Pro Kit PK2504A Rev. A03


typo: s/PG28/PG23/

asmellby · 2025-07-21T08:14:54Z

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a-pinctrl.dtsi

+
+	eusart1_default: eusart1_default {
+		group0 {
+			pins = <EUSART1_TX_PC1>; //<EUSART1_TX_PB5>;


Commented-out pinout should be removed (Zephyr requires C-style comments, but the alternate pin selection should not be here in the first place).

But more fundamentally: PC1/PC2 seem to be connected to the LCD, and aren't available as breakout pins. Should EUSART1 be configured at all?

Removed eusart1

asmellby · 2025-07-21T08:15:42Z

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a.dts

+
+&gpiob {
+	status = "okay";
+	// VCOM Isolation. Set PB1 to HIGH to enable VCOM_{RX,TX}.


C++ style comment

asmellby · 2025-07-21T08:19:05Z

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a.dts

+	status = "okay";
+	regulator-boot-on;
+	regulator-initial-mode = <SILABS_DCDC_MODE_BUCK>;
+	silabs,pfmx-peak-current-milliamp = <80>;


In SiSDK, the config option SL_DEVICE_INIT_DCDC_PFMX_IPKVAL_OVERRIDE is not set on this board. This line should be removed to make the configuration match SiSDK.

asmellby · 2025-07-21T08:28:41Z

include/zephyr/dt-bindings/clock/silabs/xg28-clock.h

Please generate a complete clock config header using the script in hal_silabs.

Generated the xg28 using the python script. Had to change a few clock configuration in xg28.dtsi file

asmellby · 2025-07-21T08:30:51Z

soc/silabs/silabs_s2/efm32pg23/Kconfig.defconfig

Please rename efr32zg23 to xg23 and add the PG23 config to that directory rather than introducing a new one.

I refactored this. Please, take a look if did not corrupt anything.

asmellby · 2025-07-21T08:40:02Z

soc/silabs/silabs_s2/efm32pg28/Kconfig

Please introduce a directory xg28 for the pg28 content, in order to avoid needing to rename it when more xg28 families are added

I added the folder.

asmellby · 2025-07-21T08:40:35Z

soc/silabs/silabs_s2/efm32pg28/Kconfig.defconfig

+
+config NUM_IRQS
+	# must be >= the highest interrupt number used
+	default 75


pg28 has 79 external interrupts, not 75

asmellby · 2025-07-21T08:42:51Z

west.yml

@@ -235,7 +237,8 @@ manifest:
      groups:
        - hal
    - name: hal_silabs
-      revision: 190a144a16bed9a938a94543ed5bbc70c0552e0f
+      remote: hal_silabs_pr


Please point to the PR in the upstream using the pull/95/head revision, don't introduce your personal remote. That PR will also need to be rebased.

janchri · 2025-07-21T22:55:31Z

Thank a lot for the feedback @asmellby

Adding xg23_pk2504a and xg28_pk2506a boards files. Signed-off-by: Christoph Jans <[email protected]>

Add device tree and support files for xg23 and xg28 dev Kit boards. Signed-off-by: Christoph Jans <[email protected]>

Introducing the efm32pg23 and efm32pg28 Series 2 Silabs chips. Signed-off-by: Christoph Jans <[email protected]>

sonarqubecloud · 2025-07-21T23:19:46Z

Please retry analysis of this Pull-Request directly on SonarQube Cloud

nordicjm · 2025-07-22T06:37:58Z

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a.dts

+
+	leds {
+		compatible = "gpio-leds";
+		led0: led_0 {


newline missing lines 37, 50, etc.

nordicjm · 2025-07-22T06:38:09Z

boards/silabs/dev_kits/xg23_pk2504a/xg23_pk2504a.dts

+&gpiob {
+	status = "okay";
+	/* VCOM Isolation. Set PB1 to HIGH to enable VCOM_{RX,TX}. */
+	board-controller-enable {


145 newline missing

nordicjm · 2025-07-22T06:38:28Z

boards/silabs/dev_kits/xg28_pk2506a/xg28_pk2506a.dts

+
+	leds {
+		compatible = "gpio-leds";
+		led0: led_0 {


fix in whole PR

nordicjm · 2025-07-22T06:39:37Z

soc/silabs/silabs_s2/xg23/Kconfig.soc

+config SOC_SERIES_EFM32PG23
+	bool
+	select SOC_FAMILY_SILABS_S2
+	select SOC_SERIES_XG23
+	help
+	  Silicon Labs EFM32PG23 Series MCU


seemingly I've not noticed this before, there should only be one SOC_SERIES_* Kconfig, not one selecting another, and that series needs to match up with what is in the soc.yml file @jerome-pouiller please remove existing usage in tree and fix it up in another PR

nordicjm · 2025-07-22T06:40:56Z

soc/silabs/silabs_s2/xg23/Kconfig.soc

+config SOC
+	default "efr32zg23b020f512im48" if SOC_PART_NUMBER_EFR32ZG23B020F512IM48
+	default "efm32pg23b310f512im48" if SOC_PART_NUMBER_EFM32PG23B310F512IM48


and this select is done based on a SOC_X Kconfig, not a part number Kconfig, so:

config SOC default "efr32zg23b020f512im48" if SOC_EFR32ZG23B020F512IM48

Again, matching up with what is in a soc.yml file

zephyrbot added area: Clock Control platform: Silabs Silicon Labs area: DMA Direct Memory Access area: Pinctrl labels Jul 17, 2025

zephyrbot requested review from asmellby, gmarull, jerome-pouiller, jhedberg, Martinhoff-maker, nordic-krch and teburd July 17, 2025 20:25

zephyrbot assigned nordic-krch Jul 17, 2025

github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 17, 2025

nordicjm requested changes Jul 18, 2025

View reviewed changes

janchri force-pushed the tmp_rebase branch 2 times, most recently from c557aae to 1f89892 Compare July 18, 2025 15:38

janchri requested a review from nordicjm July 18, 2025 15:45

janchri force-pushed the tmp_rebase branch 2 times, most recently from 0eae543 to dcf914d Compare July 19, 2025 22:47

asmellby requested changes Jul 21, 2025

View reviewed changes

janchri force-pushed the tmp_rebase branch from dcf914d to f9c7fc1 Compare July 21, 2025 22:48

janchri added 3 commits July 22, 2025 01:04

boards: Add support for PG23 Pro Kit and PG28 Pro Kit

f03370c

Adding xg23_pk2504a and xg28_pk2506a boards files. Signed-off-by: Christoph Jans <[email protected]>

boards: add dts and bindings for efm32pg23 and efm32pg28

9033306

Add device tree and support files for xg23 and xg28 dev Kit boards. Signed-off-by: Christoph Jans <[email protected]>

soc: silabs: Add support for efm32pg23 and efm32pg28

885332c

Introducing the efm32pg23 and efm32pg28 Series 2 Silabs chips. Signed-off-by: Christoph Jans <[email protected]>

janchri force-pushed the tmp_rebase branch from f9c7fc1 to 885332c Compare July 21, 2025 23:12

nordicjm requested changes Jul 22, 2025

View reviewed changes

nordicjm reviewed Jul 22, 2025

View reviewed changes

boards: Add support for PG23/PG28 Pro Kit #93285

Are you sure you want to change the base?

boards: Add support for PG23/PG28 Pro Kit #93285

Conversation

janchri commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

github-actions bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janchri commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 17, 2025 •

edited

Loading

janchri commented Jul 21, 2025 •

edited

Loading