Skip to content

Conversation

GeorgeCGV
Copy link
Contributor

  • Use existing FMC_NORSRAM_DEVICE and FMC_NORSRAM_EXTENDED_DEVICE
    defines. There is no need to keep references to them in the driver's config.
  • Refine initialization loop.
  • Add NSBank value validation at build time. Helps to catch invalid configurations earlier.

@GeorgeCGV
Copy link
Contributor Author

Unrelated LLEXT test fails:

llext.readonly_mpu on qemu_cortex_r5/zynqmp_rpu failed (Timeout)

@GeorgeCGV GeorgeCGV force-pushed the stm32_memc_psram_corrections branch from 4b92bcd to 10f3554 Compare July 22, 2025 08:11
@GeorgeCGV GeorgeCGV force-pushed the stm32_memc_psram_corrections branch from 10f3554 to 28f6f61 Compare July 23, 2025 05:23
erwango
erwango previously approved these changes Jul 23, 2025
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking review comment, otherwise LGTM.

Simplifies the driver code:
* Use existing FMC_NORSRAM_DEVICE and FMC_NORSRAM_EXTENDED_DEVICE
  defines. No need to keep references to them in the driver's config.
* Refine initialization loop.

Signed-off-by: Georgij Černyšiov <[email protected]>
Ensure NSBank values are validated at build time.
That helps to identify and fix incorrect bank values.

Signed-off-by: Georgij Černyšiov <[email protected]>
Copy link

@kartben kartben merged commit f38a326 into zephyrproject-rtos:main Aug 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants