tests: net: http: also build with clang #93386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
added
the
Trivial
fabiobaltieri
previously approved these changes
Jul 20, 2025
jukkar
previously approved these changes
Jul 20, 2025
zephyrbot
requested review from
gchwier,
golowanow,
hakehuang,
KamilxPaszkiet,
LukaszMrugala and
PerMac
nashif
removed
the
Trivial
rlubos
previously approved these changes
Jul 21, 2025
hakehuang
previously approved these changes
Jul 21, 2025
stephanosio
reviewed
Jul 21, 2025
| - qemu_x86 | ||
| integration_platforms: | ||
| - qemu_x86 | ||
| net.http.server.toolchain: |
There was a problem hiding this comment.
Should it not be called net.http.server.tls.toolchain?
nashif
force-pushed
the
topic/clang/http_coverage
branch
from
8cdd4bb to
bbea9fc
Compare
cfriedt
requested changes
Jul 30, 2025
There was a problem hiding this comment.
@nashif - I agree with @stephanosio . Can you please update the name of the test configuration?
Build this test also with clang to increase coverage. This test is selected because it had some issues with clang, however, there is nothing special about this tests when it comes to clang, it will be one of many to come to increase coverage. Signed-off-by: Anas Nashif <[email protected]>
detailed test id is no longer default, so switch the logic to deal with that. Signed-off-by: Anas Nashif <[email protected]>
Make sure we get same test with different tests included. Signed-off-by: Anas Nashif <[email protected]>
now no-detailed-test-id is enabled by default, so switch the logic so we do not require the extra parameter when reruning. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/clang/http_coverage
branch
from
bbea9fc to
f3b42f3
Compare
|
cfriedt
approved these changes
Jul 31, 2025
rlubos
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build this test also with clang to increase coverage. This test is
selected because it had some issues with clang, however, there is
nothing special about this tests when it comes to clang, it will be one
of many to come to increase coverage.
Signed-off-by: Anas Nashif [email protected]