drivers: mipi_dbi: stm32: move barriers outside of the loop #93584
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
danieldegrasse,
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
marwaiehm-st and
mathieuchopstm
There was a problem hiding this comment.
Have you verified that this works on HW?
AFAICT, this is writing different datum to the same address several times in a row (I guess a FIFO of sorts?)... and I'm worried that not executing the barrier after each write could cause issues. (though, I guess the MMIO region is Device or even Strongly-ordered memory, so it might be fine)
GeorgeCGV
force-pushed
the
drivers/mipi_dbi/stm32/correct_barriers
branch
from
c92a81a to
8b39686
Compare
GeorgeCGV
force-pushed
the
drivers/mipi_dbi/stm32/correct_barriers
branch
from
8b39686 to
cfdb502
Compare
Relocate __DSB barriers outside the data write loops to improve efficiency. Signed-off-by: Georgij Černyšiov <[email protected]>
GeorgeCGV
force-pushed
the
drivers/mipi_dbi/stm32/correct_barriers
branch
from
cfdb502 to
5e048c0
Compare
|
mathieuchopstm
approved these changes
Jul 30, 2025
|
@avolmat-st PTAL if possible |
erwango
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocate
__DSBbarriers outside the data write loops to improve efficiency.