samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

cvinayak · 2025-08-10T05:33:39Z

Update broadcaster_multiple sample to start multiple advertising sets of type legacy and extended advertising.

How they appear on-air (BabbleSim import), for 4 advertising sets:

Copilot

Pull Request Overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T14:36:09Z

samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c

+		const struct adv_param_config {
+			uint32_t options;
+			const struct bt_data *ad;
+			size_t ad_size;
+		} param_config[] = {


[nitpick] The struct adv_param_config is defined inside the function scope and used locally. Consider moving this struct definition outside the function or to a header file to improve code organization and potential reusability.

Copilot · 2025-10-11T14:36:09Z

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

+ * configured, and 1 advertising set is calculating the aux_offset, 2 other advertising sets and 2
+ * scanning instances can expire changing the ticks_current value while we are querying for
+ * aux_offset value.
+ */


The magic number 2U in the macro definition lacks explanation. Consider adding a comment to explain what this number represents (e.g., '2 scanning instances' as mentioned in the comment above).

Suggested change

*/

*/

/* 2U represents the maximum number of scanning instances that can expire and change ticks_current. */

samples/bluetooth/broadcaster_multiple/sample.yaml

JarmouniA · 2025-10-11T14:58:31Z

samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf

remove overlay from name, overlay terminology is for DT (I know there are other files named that way, but it's wrong).

It is followed across the net, drivers and bluetooth subsystem... and KConfig settings too refer to applications can have SoC overlay configuration that is applied to it or phrase like overlay configuration files here: https://docs.zephyrproject.org/latest/build/kconfig/setting.html

Hence, outside the scope of this PR. You may request a github issue to update rest of the repository and Kconfig settings documentation with a suitable proposal.

samples/bluetooth/observer/sample.yaml

samples/bluetooth/observer/overlay-bt_ll_sw_split.conf

samples/bluetooth/observer/README.rst

tests/bsim/bluetooth/host/adv/chain/src/main.c

cvinayak · 2025-10-15T07:30:26Z

samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf

Rename this file to bt_ll_sw_split.conf

cc @nordicjm

cvinayak · 2025-10-15T07:30:44Z

samples/bluetooth/observer/overlay-bt_ll_sw_split.conf

Rename this file to bt_ll_sw_split.conf

cc @nordicjm

cvinayak · 2025-10-15T07:31:17Z

samples/bluetooth/hci_uart/overlay-all-bt_ll_sw_split.conf

Rename this file to bt_ll_sw_split-all.conf

cc @nordicjm

cvinayak · 2025-10-15T07:31:29Z

samples/bluetooth/hci_uart_3wire/overlay-all-bt_ll_sw_split.conf

Rename this file to bt_ll_sw_split-all.conf

cc @nordicjm

cvinayak · 2025-10-15T07:31:45Z

tests/bsim/bluetooth/audio/overlay-bt_ll_sw_split.conf

Rename this file to bt_ll_sw_split.conf

cc @nordicjm

Copilot

Pull Request Overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-15T07:34:26Z

samples/bluetooth/broadcaster_multiple/src/broadcaster_multiple.c

 		/* Use advertising set instance index as SID */
 		adv_param.sid = index;

+		/* Advertising set options, AD and AD array size */


Using modulo operation to cycle through configurations could be confusing when CONFIG_BT_EXT_ADV_MAX_ADV_SET is not a multiple of param_config array size. Consider adding a comment explaining this behavior or bounds checking.

Suggested change

/* Advertising set options, AD and AD array size */

/* Advertising set options, AD and AD array size */

/*

* Cycle through param_config using modulo operation.

* If CONFIG_BT_EXT_ADV_MAX_ADV_SET is greater than ARRAY_SIZE(param_config),

* configurations will repeat for additional advertising sets.

* This is intentional; update param_config or CONFIG_BT_EXT_ADV_MAX_ADV_SET

* if a one-to-one mapping is required.

*/

Copilot · 2025-10-15T07:34:26Z

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

+	LL_ASSERT_MSG((ticks_elapsed <= ticks_to_start), "%s overhead = %u (%u) us.",
+		      __func__, HAL_TICKER_TICKS_TO_US(ticks_elapsed),
+		      HAL_TICKER_TICKS_TO_US(ticks_to_start));


The assertion message format string expects 3 arguments but only provides 2 after %s. This will cause undefined behavior in the assertion message formatting.

Enable similar Controller Kconfig features between nRF52 and nRF5340 BabbleSIM LE Audio testing. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Tune the aux offset calculation overhead assertion to use EVENT_OVERHEAD_START_US; this is the correct maximum overhead causing ISR latency for start of a radio event that occurs thereafter. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Update broadcaster_multiple sample to start multiple advertising sets of type legacy and extended advertising. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Move Zephyr Controller Kconfigs to overlay file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Move harness and tags to common section for observer and broadcaster_multiple samples. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Do not use the BT_ prefix for definitions not provided by the Bluetooth subsystem. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

sonarqubecloud · 2025-10-28T12:56:30Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch 9 times, most recently from 771caba to 7afe802 Compare August 11, 2025 04:29

cvinayak marked this pull request as ready for review August 11, 2025 05:10

zephyrbot added platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim area: Bluetooth Controller area: Samples Samples area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth Audio area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth labels Aug 11, 2025

github-project-automation bot moved this to In Review in Bluetooth LE Audio Aug 11, 2025

github-project-automation bot added this to Bluetooth LE Audio Aug 11, 2025

zephyrbot requested review from HaavardRei, alwa-nordic, asbjornsabo, fredrikdanebjer, hermabe, jhedberg, jthm-ot, kartben, larsgk, nashif and niym-ot August 11, 2025 05:11

github-project-automation bot added this to Bluetooth LE Audio Oct 3, 2025

github-project-automation bot moved this to In Review in Bluetooth LE Audio Oct 3, 2025

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch from 4819544 to 394c10b Compare October 11, 2025 14:35

cvinayak requested review from Thalley and Copilot October 11, 2025 14:35

Copilot AI reviewed Oct 11, 2025

View reviewed changes

zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 11, 2025

JarmouniA reviewed Oct 11, 2025

View reviewed changes

cvinayak mentioned this pull request Oct 13, 2025

samples: mgmt: mcumgr: smp_svr: Remove overlay from Kconfig files #96847

Merged

Thalley requested changes Oct 13, 2025

View reviewed changes

tests/bsim/bluetooth/host/adv/chain/src/main.c Outdated Show resolved Hide resolved

Thalley removed this from Bluetooth LE Audio Oct 14, 2025

cvinayak requested a review from Thalley October 14, 2025 14:35

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch 2 times, most recently from 427feb4 to f815c12 Compare October 14, 2025 17:16

cvinayak commented Oct 15, 2025

View reviewed changes

cvinayak requested review from JarmouniA, Copilot and nordicjm October 15, 2025 07:32

Copilot AI reviewed Oct 15, 2025

View reviewed changes

cvinayak removed this from the v4.3.0 milestone Oct 17, 2025

cvinayak added this to the v4.4.0 milestone Oct 27, 2025

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch from f815c12 to 56d6b00 Compare October 27, 2025 19:21

cvinayak added 6 commits October 28, 2025 13:28

tests: bsim: Bluetooth: Enable similar Controller Kconfig features

8031972

Enable similar Controller Kconfig features between nRF52 and nRF5340 BabbleSIM LE Audio testing. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

samples: Bluetooth: Broadcast multiple legacy and extended advertising

addc754

Update broadcaster_multiple sample to start multiple advertising sets of type legacy and extended advertising. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

samples: Bluetooth: observer: Move Zephyr Controller Kconfigs

612ef6d

Move Zephyr Controller Kconfigs to overlay file. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

samples: Bluetooth: Move harness and tags to common section

9ec0295

Move harness and tags to common section for observer and broadcaster_multiple samples. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

tests: bsim: Bluetooth: Do not use the BT_ prefix

1209301

Do not use the BT_ prefix for definitions not provided by the Bluetooth subsystem. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch from 56d6b00 to 1209301 Compare October 28, 2025 12:29

	*/
	*/
	/* 2U represents the maximum number of scanning instances that can expire and change ticks_current. */

-		/* Advertising set options, AD and AD array size */
+		/* Advertising set options, AD and AD array size */
+		/*
+		 * Cycle through param_config using modulo operation.
+		 * If CONFIG_BT_EXT_ADV_MAX_ADV_SET is greater than ARRAY_SIZE(param_config),
+		 * configurations will repeat for additional advertising sets.
+		 * This is intentional; update param_config or CONFIG_BT_EXT_ADV_MAX_ADV_SET
+		 * if a one-to-one mapping is required.
+		 */

samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

Are you sure you want to change the base?

samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

Conversation

cvinayak commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JarmouniA Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cvinayak Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 28, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cvinayak commented Aug 10, 2025 •

edited

Loading