Skip to content

Add support for SPI transfers on RM3100 and fix DT yaml typo #95882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

Add support for SPI transfers on RM3100 and fix DT yaml typo #95882

merged 2 commits into from
Sep 30, 2025

Conversation

anthony289478
Copy link
Contributor

@anthony289478 anthony289478 commented Sep 11, 2025 •
edited
Loading

Add support for SPI transfers using RTIO and fix minor typo in DT yaml to match rm3100.h defs.

@zephyrbot zephyrbot added the area: Sensors Sensors label Sep 11, 2025
@anthony289478 anthony289478 force-pushed the rm3100-rtio-spi branch 3 times, most recently from 2895c31 to 04250e2 Compare September 12, 2025 02:17
teburd
teburd reviewed Sep 13, 2025
View reviewed changes
Copy link
Contributor

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me with some minor feedback

ubieda
ubieda reviewed Sep 15, 2025
View reviewed changes
@ubieda ubieda mentioned this pull request Sep 15, 2025
Merged
@anthony289478 anthony289478 force-pushed the rm3100-rtio-spi branch 2 times, most recently from 5861d72 to 76d51cd Compare September 15, 2025 20:25
ubieda
ubieda reviewed Sep 24, 2025
View reviewed changes
drivers/sensor/pni/rm3100/rm3100.c Outdated
LOG_ERR("Failed to trigger POLL");
rtio_iodev_sqe_err(iodev_sqe, err);
} else {
rm3100_stream_submit(dev, iodev_sqe);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we shouldn't be calling rm3100_stream_submit() unless it is indeed streaming (multi-shot events).

I suspect if the intend is to manually poll each sample to better control the ODR pace, then you don't expect to use the streaming-mode, yeah?

If that's the case, I suggest making them mutually exclusive and then handle the GPIO config-firing on a file separate from rm3100_stream.c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats fine, the logic will be basically a direct copy paste of what is used in rm3100_stream.c which is why I chose to reuse the function.

ubieda
ubieda reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW - The first two patches look good and straightforward to me: If you want to file a standalone PR to address the GPIO-driven one-shot reads, that's good with me as well.

@anthony289478
Copy link
Contributor Author

FWIW - The first two patches look good and straightforward to me: If you want to file a standalone PR to address the GPIO-driven one-shot reads, that's good with me as well.

Sure

@anthony289478 anthony289478 changed the title Add support for SPI transfers on RM3100 and one-shots using GPIO Add support for SPI transfers on RM3100 and fix DT yaml typo Sep 24, 2025
@anthony289478
sensor: rm3100: Add support for SPI
02a39b2 
Add support for SPI

Signed-off-by: Anthony Williams <[email protected]>
@anthony289478
sensor: rm3100: Fix typo in DT yaml
47624ec 
Rename RM33100 to RM3100 in yaml comment to align
with rm3100.h defines.

Signed-off-by: Anthony Williams <[email protected]>
@anthony289478
Copy link
Contributor Author

one-shot is moved to #96522
For reference, the force rebase branch from 9e98103 to 47624ec was because github actions was giving weird errors. Last time this happened it was because I was too far out of date.

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@kartben kartben merged commit bfa6f4a into zephyrproject-rtos:main Sep 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@ubieda ubieda ubieda approved these changes

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@avisconti avisconti Awaiting requested review from avisconti

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@tristan-google tristan-google Awaiting requested review from tristan-google

@yperess yperess Awaiting requested review from yperess

@teburd teburd Awaiting requested review from teburd

Assignees

@MaureenHelm MaureenHelm

Labels

area: Sensors Sensors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anthony289478 @teburd @MaureenHelm @ubieda @kartben @zephyrbot