checkpatch: add 2 new rules to enforce capitilization in macro constants #95904
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
reviewed
Sep 12, 2025
- Detects #define statements with lowercase macro names - Detects enum labels starting with lowercase letters Fixes zephyrproject-rtos#95679 Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/cg/checkpatch_case
branch
from
7b34e4b to
9ed2be7
Compare
Thalley
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
The latest patch seem to give the expected result
WARNING : Test Checkpatch warning:
MACRO_CASE: Macro name 'DUM_DUM_val' should be capitalized (names of macros defining constants should be capitalized)
File:include/zephyr/bluetooth/bluetooth.h
Line:49
WARNING : Test Checkpatch warning:
MACRO_CASE: Macro name 'dum_dum_val' should be capitalized (names of macros defining constants should be capitalized)
File:include/zephyr/bluetooth/bluetooth.h
Line:50
WARNING : Test Checkpatch warning:
ENUM_CASE: Enum label 'dummy_val' should be capitalized (names of labels in enums should be capitalized)
File:include/zephyr/bluetooth/bluetooth.h
Line:53
|
zephyrbot
requested review from
carlescufi,
jfischer-no,
keith-zephyr and
simhein
| my $enum_name = $1; | ||
| my $in_enum = 0; | ||
| # Look back to see if we're inside an enum | ||
| for (my $ln = $linenr - 1; $ln >= $linenr - 20 && $ln >= 0; $ln--) { |
There was a problem hiding this comment.
I searching back 20 lines enough?
zephyr/arch/xtensa/core/gdbstub.c
Line 25 in df0cb36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95679
Signed-off-by: Anas Nashif [email protected]