Add support System Timer for Renesas RZ/V2L, RZ/A3UL #95989
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_renesas
DNM (manifest)
zephyrbot
added
area: ARM64
zephyrbot
requested review from
aaillet,
andyross,
binhnguyen2434,
ceolin,
cfriedt,
dcpleung,
KhiemNguyenT,
lorc,
nashif,
nhutnguyenkc,
npitre,
peter-mitsis,
TaiJuWu,
tgorochowik and
xakep-amatop
| @@ -51,28 +51,37 @@ static uint32_t cyc_per_tick; | |||
| #define CYC_PER_TICK cyc_per_tick | |||
|
|
|||
| static void ostm_irq_handler(timer_callback_args_t *arg); | |||
| void gtm_int_isr(void); | |||
| void gtm_int_isr(void *irq); | |||
There was a problem hiding this comment.
Please correct me if I am wrong, but this prototype does not appear to match the prototype in pull/130
There was a problem hiding this comment.
Thanks, the RZA and RZV series define this prototype differently:
- RZA:
void gtm_int_isr(IRQn_Type const irq);(https://github.com/renesas/hal_renesas/blob/69cc903f11517985898dca578ac86b32e83374c5/drivers/rz/fsp/src/rza/r_gtm/r_gtm.c#L44) - RZV:
void gtm_int_isr(void);(https://github.com/renesas/hal_renesas/blob/69cc903f11517985898dca578ac86b32e83374c5/drivers/rz/fsp/src/rzv/r_gtm/r_gtm.c#L43)
Therefore, this prototype change is intended to unify the implementation and allow using a common source for both series.
There was a problem hiding this comment.
I had expected that the HAL would have standardized around void gtm_int_isr(IRQn_Type const irq); and ignore the unused parameter for the rzg and rzv cases.
There was a problem hiding this comment.
Thanks for your suggestion. Would you consider this a blocker? It's like a callback function which is usually defined with a void* argument to accept any type of data, making it less dependent on the HAL driver.
There was a problem hiding this comment.
I suppose it would be a blocker to me. I can pretty much guarantee that if we don't address this now, we are going to have to address it later when any of the following occur ...
- Someone else notices the mismatch and raises an issue.
- A software quality tool flags the mismatch leading to a raised issue.
- A linker from another toolchain decides to raise a warning or even an error about it.
It is better in my mind to fix it now instead of later.
tiennguyenzg
force-pushed
the
rz_support_system_timer
branch
from
291f150 to
0137ecb
Compare
github-actions
bot
removed
the
DNM (manifest)
zephyrbot
requested review from
decsny,
dleach02,
mmahadevan108 and
peter-mitsis
Add system timer driver support for RZ/V2L, RZ/A3UL Signed-off-by: Hoang Nguyen <[email protected]> Signed-off-by: Tien Nguyen <[email protected]>
Add gtm, os_timer nodes to Renesas RZ/V2L, RZ/A3UL Signed-off-by: Hoang Nguyen <[email protected]> Signed-off-by: Tien Nguyen <[email protected]>
Select ARM_ARCH_TIMER when RZ_OS_TIMER is not selected Signed-off-by: Hoang Nguyen <[email protected]> Signed-off-by: Tien Nguyen <[email protected]>
Add tickless concept test support for RZ/V2L-SMARC, RZ/A3UL-SMARC Signed-off-by: Hoang Nguyen <[email protected]> Signed-off-by: Tien Nguyen <[email protected]>
tiennguyenzg
force-pushed
the
rz_support_system_timer
branch
from
0137ecb to
178223e
Compare
|
Add support system timer for Renesas RZ/V2L, RZ/A3UL:
drivers/counter/renesas_rz_gtm_timer.cto using common source code for Renesas RZ devicestests/kernel/tickles/tickless_concepttestNeed: zephyrproject-rtos/hal_renesas#130