Skip to content

Conversation

cyliangtw
Copy link
Contributor

This PR is to add Nuvoton NuMaker M333x SoC series.

This PR depends on zephyrproject-rtos/hal_nuvoton#20

Copy link

github-actions bot commented Sep 16, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nuvoton zephyrproject-rtos/hal_nuvoton@be1042d zephyrproject-rtos/hal_nuvoton@d46a377 (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm
nordicjm previously approved these changes Sep 16, 2025
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SoC files OK, though would be better to have a board so it can be seen that the files are error free and can build

Add initial support for Nuvoton NuMaker-M333x SoC series,
including basic initialization and device tree includes.

Signed-off-by: cyliang tw <[email protected]>
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Sep 17, 2025
Copy link

@cyliangtw
Copy link
Contributor Author

SoC files OK, though would be better to have a board so it can be seen that the files are error free and can build

Thanks of your advice.
I verified it with local board files before submitting this PR.

i.e: Based on prior PR feedback, some reviewer suggested splitting small PRs into fewer files, so I separated it into an SoC PR and a board PR.

@nordicjm
Copy link
Contributor

SoC files OK, though would be better to have a board so it can be seen that the files are error free and can build

Thanks of your advice. I verified it with local board files before submitting this PR.

i.e: Based on prior PR feedback, some reviewer suggested splitting small PRs into fewer files, so I separated it into an SoC PR and a board PR.

It's fine to have a SoC and board PR - so long as they are in different commits i.e. not one huge commit with files all over the place

@decsny decsny removed their request for review September 18, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants