enable ethernet support on the stm32mp135f-dk #96134

arnopo · 2025-09-17T09:42:10Z

This Pull reuest enable the support of the ethernet 1 instance

Hardware details:

the PHY is a LAN8742A with an Hardware reset based on a GPIO.
the clock reference is an externl crystal running at 25 Mhz
16K of non cacheable memory in the SYSRAM is used to store ethernet DMA Buffers and descriptors

Samples tested:

samples/net/ipv4_autoconf
samples/net/dhcpv4_client

Known current limitation:

Ethernet2 instance not implemented
sample/net/zperf not build

github-actions · 2025-09-17T09:46:39Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_stm32	zephyrproject-rtos/hal_stm32@`d768bcb`	zephyrproject-rtos/hal_stm32@`b6f03b6` (`main`)	zephyrproject-rtos/[email protected]

Additional metadata changed:

Name	URL	Submodules	West cmds	`module.yml`	Blobs
hal_stm32				✏	2x ✏

⛔ DNM label due to: 1 project with metadata changes and 2 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

boards/st/stm32mp135f_dk/stm32mp135f_dk_defconfig

boards/st/stm32mp135f_dk/stm32mp135f_dk.dts

erwango · 2025-09-17T09:56:20Z

FYI, it'll have to be rebased on top of #96095

maass-hamburg · 2025-09-17T11:44:27Z

dts/bindings/ethernet/phy/ethernet-phy.yaml

+  reset-gpios:
+    type: phandle-array
+    description: |
+      This reset gpio can be used for PHY with hardware reset.


the ethernet-phy driver is meant to be generic and only implement features, that are defined in the ethernet standard IEEE 802.3. It doesn't specify a reset pin, only the register, which should be enought. If you want a reset pin, you have to create a specific phy driver.

I have created a LAN8742 inspired from ethernet_phy

drivers/ethernet/eth_stm32_hal_v2.c

erwango · 2025-09-18T12:36:04Z

drivers/ethernet/eth_stm32_hal_v2.c


+#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32mp13_ethernet)
+	/* APO test : TBD */
+	heth->Init.ClockSelection =  cfg->ClockSelection;


Ideally please use clock_control_configure()

I would prefer not use it. The concerning register is a SYSCFG register that is updated by HAL_ETH_Init() function.
If I set it before calling HAL_ETH_Init() it will overwritte it
Else if set it after HAL_ETH_Init() it could generate side effect.

dts/bindings/ethernet/st,stm32mp13-ethernet.yaml

arnopo · 2025-09-25T14:49:20Z

To be able to run Zperf we need #96575

Add new flags to allow to select normal and strong ordered attributes for non-cacheable memory. This is needed for armV7 to be able to configure all non cacheable memories with another attribute than "device" attribute. Signed-off-by: Arnaud Pouliquen <[email protected]>

Selecting MT_DEVICE for non cache-able memory does no work in all use cases. For instance for net samples a non-cacheable memory can be used for descriptors and buffers exchanged between the lib and the hardware. In such context, the net lib can perform some non word aligned memory this lead to an alignment data abort if the attribute is MT_DEVICE. Memories attribute should be MT_NORMAL, allowing non aligned transfer Signed-off-by: Arnaud Pouliquen <[email protected]>arch: arm: mmu: allow selecting memory type for non-cacheable memory

New hal_stm32 revision contains pincontrol for the etherent support. Signed-off-by: Arnaud Pouliquen <[email protected]>

Introduce stm32mp13 bindings to support the ethernet peripherals. The "memory-regions" property is used to reference non cacheable memory for the ETH DMA. The "st,ext-phyclk" property aligned Linux binding is used to specify the PHY clock for RMII. Signed-off-by: Arnaud Pouliquen <[email protected]>

Add basic support of the LAN8742 RMII phy. The driver is inspired from the phy_mii generic driver, with the support of a GPIO reset. Signed-off-by: Arnaud Pouliquen <[email protected]>

The GPIO_MCP230XX config currently depends on the I2C config. This means that the board/SoC must enable the I2C config to support MCP23xxx devices. Inverting this dependency allows declaring GPIO_MCP230XX directly in the board/SoC defconfig without explicitly enabling I2C. Signed-off-by: Arnaud Pouliquen <[email protected]> Suggested-by Fin Maaß <[email protected]>

Enable dynamic configuration of region mapping with a 1:1 virtual-to-physical address mapping. This configuration is aligned with the static declaration of the MMU table using MMU_REGION_FLAT_ENTRY macro. Signed-off-by: Arnaud Pouliquen <[email protected]>

Add the Ethernet 0 MAC and MDIO nodes in the device tree. Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Arif Balik <[email protected]>

The typedef ETH_TxPacketConfigTypeDef is used consistently in the driver. However, some instances of ETH_TxPacketConfig have not yet been replaced. On the STM32MP13 series, the ETH_TxPacketConfig typedef is no longer defined. This cleanup ensures compatibility and consistency. Signed-off-by: Arnaud Pouliquen <[email protected]>

Add the support of the stm32mp13 ethernet: - Adapt to HAL API - Add support of a memory region in DT for descriptor and buffers - Add support of PHY with/without crystal 50MHz Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Arif Balik <[email protected]>

The STM32MP135F-DK board embeds 2 ethernets. Enable the ethernet1 in RMII mode with associated PHY. Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Arif Balik <[email protected]>

sonarqubecloud · 2025-10-06T09:31:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

erwango · 2025-10-17T14:26:55Z

west.yml

        - hal
    - name: hal_stm32
-      revision: d768bcbf9b6f75b46eff274b343a9556c0ce108d
+      revision: b6f03b6efd92da4564b38df8cb54d7dad5f37163


Let's drop this, as this was updated via other PRs

erwango · 2025-10-17T14:36:09Z

drivers/ethernet/eth_stm32_hal_v2.c

+#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32mp13_ethernet)
+		HAL_ETH_TxFreeCallback(heth, (uint32_t *)ctx);
+#else
 		HAL_ETH_TxFreeCallback((uint32_t *)ctx);
+#endif


Proposal:
To avoid redundant ifdefery in the function headers, you can define a custom arg:

HAL_ETH_TxFreeCallback(STM32_ETH_ARGS(heth, (uint32_t *)ctx));

With:

#if DT_HAS_COMPAT_STATUS_OKAY(st_stm32mp13_ethernet) #define STM32_ETH_ARGS(foo, VARGS) foo, VARGS #else #define STM32_ETH_ARGS(foo, VARGS) VARGS #endif

maass-hamburg · 2025-10-17T15:25:52Z

boards/st/stm32mp135f_dk/Kconfig.defconfig

+config NET_L2_ETHERNET
+	default y if NETWORKING


use configdefault

maass-hamburg · 2025-10-17T15:26:35Z

drivers/ethernet/eth_stm32_hal_priv.h

 #define __eth_stm32_desc __attribute__((section(".eth_stm32_desc")))
 #define __eth_stm32_buf  __attribute__((section(".eth_stm32_buf")))
+#elif defined(CONFIG_SOC_SERIES_STM32MP13X)
+#define ETH_DMA_REGION  DT_PHANDLE(DT_NODELABEL(mac), memory_regions)


access by Instance and not by label

maass-hamburg · 2025-10-17T15:28:32Z

drivers/ethernet/phy/phy_microchip_lan8742.c

+
+	data->state.is_up = false;
+
+	if (!cfg->mdio) {


use the is device ready function, if at all.

juickar · 2025-10-17T14:46:22Z

include/zephyr/arch/arm/arm_mem.h

+
+/** @} */
+
+#endif /* ZEPHYR_INCLUDE_ARCH_ARM64_ARM_MEM_H_ */


-#endif /* ZEPHYR_INCLUDE_ARCH_ARM64_ARM_MEM_H_ */ +#endif /* ZEPHYR_INCLUDE_ARCH_ARM_ARM_MEM_H_ */

juickar · 2025-10-17T14:51:53Z

arch/arm/core/mmu/arm_mmu.c

 	switch (flags & K_MEM_CACHE_MASK) {

 	case K_MEM_CACHE_NONE:
+		switch (flags & K_MEM_ARM_NC_TYPE_MASK) {


title of the commit is also after the signature:
Signed-off-by: Arnaud Pouliquen [email protected]arch: arm: mmu: allow selecting memory type for non-cacheable memory

juickar · 2025-10-17T14:54:12Z

dts/bindings/ethernet/st,stm32mp13-ethernet.yaml

@@ -0,0 +1,27 @@
+# Copyright (c) 2025, STMicroelectronics


Nit:

-The "st,ext-phyclk" property aligned Linux binding is used to specify +The "st,ext-phyclk" property aligned Linux binding is used to specify

in the commit message

juickar · 2025-10-17T15:24:43Z

drivers/ethernet/Kconfig.stm32_hal


 choice ETH_STM32_HAL_API_VERSION
 	prompt "STM32Cube HAL Ethernet version"



also in this commit message:

- - Add support of PHY with/without crystal 50MHz + - Add support of PHY with/without crystal 50MHz

juickar · 2025-10-17T15:32:18Z

boards/st/stm32mp135f_dk/stm32mp135f_dk.dts

+
+	eth_ram: sram@30000000 {
+		compatible = "zephyr,memory-region", "mmio-sram";
+		reg = <0x2FFE0000 DT_SIZE_K(16)>;


why eth_ram: sram@30000000 and reg = <0x2FFE0000 ?

arnopo mentioned this pull request Sep 17, 2025

fix: scripts: mp1 series eth pin config zephyrproject-rtos/hal_stm32#287

Merged

github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 17, 2025

erwango reviewed Sep 17, 2025

View reviewed changes

boards/st/stm32mp135f_dk/stm32mp135f_dk_defconfig Outdated Show resolved Hide resolved

erwango reviewed Sep 17, 2025

View reviewed changes

boards/st/stm32mp135f_dk/stm32mp135f_dk_defconfig Outdated Show resolved Hide resolved

erwango reviewed Sep 17, 2025

View reviewed changes

boards/st/stm32mp135f_dk/stm32mp135f_dk.dts Outdated Show resolved Hide resolved

maass-hamburg requested changes Sep 17, 2025

View reviewed changes

erwango reviewed Sep 18, 2025

View reviewed changes

drivers/ethernet/eth_stm32_hal_v2.c Outdated Show resolved Hide resolved

erwango reviewed Sep 18, 2025

View reviewed changes

drivers/ethernet/eth_stm32_hal_v2.c Outdated Show resolved Hide resolved

erwango reviewed Sep 18, 2025

View reviewed changes

drivers/ethernet/eth_stm32_hal_v2.c Outdated Show resolved Hide resolved

erwango requested changes Sep 18, 2025

View reviewed changes

arnopo force-pushed the mp13_eth branch 4 times, most recently from 5ed3b84 to 86f88cc Compare September 22, 2025 15:23

arnopo force-pushed the mp13_eth branch from 86f88cc to 45a7499 Compare October 6, 2025 09:04

github-actions bot added the Binary Blobs Modified label Oct 6, 2025

arnopo added 9 commits October 6, 2025 11:12

manifest: update hal_stm32 revision to integrate ethernet on stm32mp13

603fc55

New hal_stm32 revision contains pincontrol for the etherent support. Signed-off-by: Arnaud Pouliquen <[email protected]>

drivers: ethernet: add initial support of the LAN8742 PHY

8193108

Add basic support of the LAN8742 RMII phy. The driver is inspired from the phy_mii generic driver, with the support of a GPIO reset. Signed-off-by: Arnaud Pouliquen <[email protected]>

dts: arm :st: Add ethernet 0 node in stm32mp13

31349e5

Add the Ethernet 0 MAC and MDIO nodes in the device tree. Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Arif Balik <[email protected]>

arnopo added 2 commits October 6, 2025 11:14

boards: st: stm32mp135f_dk: add ethernet nodes

80bd370

The STM32MP135F-DK board embeds 2 ethernets. Enable the ethernet1 in RMII mode with associated PHY. Signed-off-by: Arnaud Pouliquen <[email protected]> Signed-off-by: Arif Balik <[email protected]>

arnopo force-pushed the mp13_eth branch from 45a7499 to 80bd370 Compare October 6, 2025 09:14

arnopo mentioned this pull request Oct 17, 2025

ARMV7 MMU : support of the NORMAL and memory-ordered memory type #96575

Open

erwango requested a review from juickar October 17, 2025 14:26

erwango reviewed Oct 17, 2025

View reviewed changes

arnopo marked this pull request as ready for review October 17, 2025 14:29

zephyrbot requested review from ClaCodes, FRASTM, GeorgeCGV, decsny, djiatsaf-st, etienne-lms, gautierg-st, lmajewski, marwaiehm-st, mathieuchopstm and pdgendt October 17, 2025 14:31

zephyrbot assigned maass-hamburg Oct 17, 2025

erwango reviewed Oct 17, 2025

View reviewed changes

erwango added this to the v4.3.0 milestone Oct 17, 2025

maass-hamburg requested changes Oct 17, 2025

View reviewed changes

juickar suggested changes Oct 17, 2025

View reviewed changes


		choice ETH_STM32_HAL_API_VERSION
		prompt "STM32Cube HAL Ethernet version"


		/** @} */

		#endif /* ZEPHYR_INCLUDE_ARCH_ARM64_ARM_MEM_H_ */

enable ethernet support on the stm32mp135f-dk #96134

Are you sure you want to change the base?

enable ethernet support on the stm32mp135f-dk #96134

Conversation

arnopo commented Sep 17, 2025

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwango commented Sep 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arnopo commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 6, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Sep 17, 2025 •

edited

Loading

arnopo commented Sep 25, 2025 •

edited

Loading