drivers: sensor: voltage-divider: Add calibrate property #96511
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faxe1008
force-pushed
the
voltage_div_cal
branch
from
2e4e0ca to
2331bc7
Compare
zephyrbot
requested review from
asemjonovs,
avisconti,
decsny,
jeppenodgaard,
MaureenHelm,
mbolivar,
rruuaanng,
teburd,
tristan-google,
ubieda and
yperess
ubieda
reviewed
Sep 24, 2025
faxe1008
force-pushed
the
voltage_div_cal
branch
from
2331bc7 to
1233e68
Compare
ubieda
previously approved these changes
Sep 24, 2025
faxe1008
force-pushed
the
voltage_div_cal
branch
from
1233e68 to
00a2dd2
Compare
|
Had to fix the device binding (boolean instead of bool 🤦 ) |
faxe1008
force-pushed
the
voltage_div_cal
branch
from
00a2dd2 to
8650d84
Compare
I see this PR shifted towards skipping calibration instead. I wonder the rationale and if valid, the commit message should be updated. |
|
True the commit message needs to be changed. Rationale is that you can not default a binding property to true. |
Adds a skip-calibration property to the voltage divider sensor, which can be enabled, in case the underlying ADC driver does not support calibration. Signed-off-by: Fabian Blatz <[email protected]>
faxe1008
force-pushed
the
voltage_div_cal
branch
from
8650d84 to
4c1a0d6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a calibrate property to the voltage divider sensor, which can be disabled, in case the underlying ADC driver does not support calibration.
Encountered this issue while using the esp32,adc
https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/adc/adc_esp32.c#L407