refactor(mcp): async snapshot lock and workspace-scoped state#272
Closed
defin85 wants to merge 1 commit intozilliztech:masterfrom
Closed
refactor(mcp): async snapshot lock and workspace-scoped state#272defin85 wants to merge 1 commit intozilliztech:masterfrom
defin85 wants to merge 1 commit intozilliztech:masterfrom
Conversation
cc3af88 to
f598bf6
Compare
Author
|
Superseded by #274 to align with CONTRIBUTING.md branch naming (). |
Author
|
Superseded by #274 for branch naming compliance with CONTRIBUTING.md (feature/*). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Snapshot persistence used sync busy-wait lock backoff, causing high CPU under lock contention. Snapshot state was global, so multiple workspaces/sessions contended on one lock file.
Changes
process.cwd()).Breaking Changes
SnapshotManager.saveCodebaseSnapshot()is now async and must be awaited.Validation
packages/mcp/node_modules/.bin/tsc -p packages/mcp/tsconfig.json --noEmitpnpm --filter @zilliz/claude-context-mcp buildbash scripts/build-local-mcp.shpnpm build