Auto-select Milvus REST client for HTTP(S) addresses#277
Open
jarylc wants to merge 1 commit intozilliztech:masterfrom
Open
Auto-select Milvus REST client for HTTP(S) addresses#277jarylc wants to merge 1 commit intozilliztech:masterfrom
jarylc wants to merge 1 commit intozilliztech:masterfrom
Conversation
Route `milvusAddress` values matching `http://` or `https://` to the already implemented MilvusRestfulVectorDatabase. Defaults back to the gRPC-based MilvusVectorDatabase for all other addresses. This removes the need for a separate provider flag when connecting to Milvus (or equivalent REST implementation, https://gitlab.com/jarylc/cf-worker-milvus) via its RESTful API.
jarylc
force-pushed
the
milvus-restful-for-http
branch
from
1d82c3b to
111d701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route
milvusAddressvalues matchinghttp://orhttps://to the already implemented MilvusRestfulVectorDatabase. Defaults back to the gRPC-based MilvusVectorDatabase for all other addresses.This removes the need for a separate provider flag when connecting to Milvus (or equivalent REST implementation) via its RESTful API.