chore: no operation when plan is upgraded #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces logic to validate and restrict changes to the
plan
field for clusters, ensuring that only plan upgrades (not downgrades) are permitted. It also adds comprehensive tests to verify this behavior and updates test utilities accordingly.Plan change validation and enforcement:
getPlanRank
andvalidatePlanUpgrade
helper functions incluster_resource.go
to determine plan hierarchy and prevent downgrades, allowing only plan upgrades. (internal/cluster/cluster_resource.go
internal/cluster/cluster_resource.goR427-R463)Update
method inClusterResource
to use the new validation logic when the plan changes, returning an error if a downgrade is attempted. (internal/cluster/cluster_resource.go
internal/cluster/cluster_resource.goR491-R502)isClusterPlanChanged
method toClusterResourceModel
to detect plan changes. (internal/cluster/model.go
internal/cluster/model.goR71-R74)Testing enhancements:
internal/cluster/cluster_resource_test.go
internal/cluster/cluster_resource_test.goR325-R453)internal/cluster/cluster_resource_test.go
internal/cluster/cluster_resource_test.goR20-R24)ImportStateVerifyIgnore
lists in relevant tests to include theplan
field, preventing false negatives during import state verification. (internal/cluster/cluster_resource_test.go
[1] [2] [3]Test utility import:
regexp
package import to support error matching in tests. (internal/cluster/cluster_resource_test.go
internal/cluster/cluster_resource_test.goR5)