Finalized state #723
Closed
Finalized state #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zancas
force-pushed
the
finalized_state
branch
from
101b834 to
1937f1a
Compare
nachog00
reviewed
Nov 26, 2025
| @@ -1,5 +1,5 @@ | |||
| # ──────────────────────────────────────────────────────────────────────────────── | |||
| # Zaino – Finalised State Database, on-disk layout (Schema v1, 2025-08-05) | |||
| # Zaino – Finalized State Database, on-disk layout (Schema v1, 2025-08-05) | |||
Contributor
There was a problem hiding this comment.
I belive our DB impl does some hashing with all db related stuff... I wonder the implicates of this change. I don't know if we have tests to assert db stability, for how delicate it seems to be (based on reactions to changing any of it in the past) I believe we might want to prioritize getting a handle on it.
Member
Author
|
Sigh... obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #728
Prior to this there was a mix of finalised and finalized..
Move finalised --> finalized