Skip to content

Conversation

Tomas-M
Copy link
Contributor

@Tomas-M Tomas-M commented Aug 21, 2025

When trying to start new wallet by importing unified viewing key to zingolib, it fails because it considers the ufvk as a seed word. It was practically impossible to import the viewing key. This patch fixes this.

The key is imported and wallet is started successfully.
When I export ufvk again from the newly created wallet, it matches the imported key byte by byte.

However, when I try "notes" or "transactions" command, I do not see any notes or transactions, even if there were many incomming and outgoing payments, even if I rescan and sync since the birthday. So I am not sure if the whole thing is correct, may need further fixing or improvements.

Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix! sorry for the inconvenience, zingo cli is not as easy to intetgration test atleast in its current form. Please can you look at fixing the fmt to pass CI? you should be able to just run cargo fmt

@Tomas-M
Copy link
Contributor Author

Tomas-M commented Aug 21, 2025

tests passed now, thanks for pointing out what to do.

Still, my patch adds the ufvk import, but I am not sure if this is everything which needs to be done, since I cannot see any transactions or notes on the wallet with imported ufvk.

@Tomas-M
Copy link
Contributor Author

Tomas-M commented Aug 22, 2025

I think there was probably something misplaced on my side when I couldnt see the transactions or notes, I tried again and it works fine now. So we can consider this patch fully functional to add working viewkey support.

@Oscar-Pepper
Copy link
Contributor

I think there was probably something misplaced on my side when I couldnt see the transactions or notes, I tried again and it works fine now. So we can consider this patch fully functional to add working viewkey support.

yes i tested it and my txs appeared so I consider this fully functional

Oscar-Pepper
Oscar-Pepper previously approved these changes Aug 22, 2025
@Tomas-M
Copy link
Contributor Author

Tomas-M commented Aug 23, 2025

Good. Would you please merge it to main dev?

@Oscar-Pepper Oscar-Pepper merged commit 26fd47f into zingolabs:dev Aug 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants