fix(query_manager): handle timeout exceptions by using a completer for response stream#1515
Merged
vincenzopalazzo merged 1 commit intozino-hofmann:mainfrom Jan 13, 2026
Conversation
…r response stream
vincenzopalazzo
approved these changes
Jan 13, 2026
Collaborator
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
LGTM, waiting on CI
AngeloAvv
deleted the
dio-link-server-exception-when-timeout-exception
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a TimeoutException thrown during a GraphQL request is not properly handled and propagates through the main stack, resulting in an unhandled exception and a Crashlytics fatal error.
When a request exceeds queryRequestTimeout, the underlying Dio call may throw a DioException (for example with HTTP status code 504). This exception is currently wrapped in a DioLinkServerException but is not correctly surfaced through
.exception, making it impossible for consumers to handle it properly.This change ensures that timeout-related errors are correctly propagated and exposed to the caller, preventing unexpected application crashes and allowing proper error handling at the application level.
Maintainers should merge this PR because it: