Clean up dependencies, update to embedded-hal digital v2 API #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only used once when `new` is called. The caller should do that by themselves if needed, but it is quite reasonable to use the keypad without it, calling poll() at strategic points. Also remove dependencies: * cortex_m is not needed at all * embedded_hal was only needed for the counter Also fix a small typo in Cargo.toml.
Since the errors from pins are usually not very useful, I opted to throw the details away, avoiding more associated types etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the need to pass a counter which is only used once, and some unused dependencies.
The second commit makes the keypad work with the embedded-hal digital::v2 API by allowing read and write to return errors.
If you find these changes to be useful, I have more ideas in mind, such as passing an optional Enum for keys names, and keeping track of press/release events.