Open
Conversation
Fix for issuehttps://github.com/foxer666/node-open-mining-portal/issues/145 You will need to test this, as your code is different from BootNOMP and I had to adjust the validation procedure.
mooleshacat
commented
Oct 31, 2018
| }, true); | ||
| } | ||
| if (!isValid) { | ||
| callback(null, workers, rounds); |
Author
There was a problem hiding this comment.
This is the only line I am unsure about. Do I just return; or do I callback and then return; to skip the worker?
If we are looping through only workers for one payout address, I believe we want both.
If we are looping through all workers for every payout address, I believe we want only "return;"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue https://github.com/foxer666/node-open-mining-portal/issues/106
You will need to test this, as your code is different from BootNOMP and I had to adjust the validation procedure.