Skip to content

Add toggle setting for Mac tray icon unread count display #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add toggle setting for Mac tray icon unread count display #1429

wants to merge 2 commits into from

Conversation

@Weiged
Copy link

@Weiged Weiged commented Jun 16, 2025

This PR improves the Mac tray icon functionality by adding user control over unread message count display and improving the visual representation.

Changes:

  • Add toggle setting to control whether to display unread message count on Mac tray icon
  • Change Mac system tray unread message display to use icon with unread count text to avoid theme-related display issues

Fixes:

Improves Mac user experience with system tray functionality. The previous implementation had issues with icon color not automatically switching between black and white based on system theme, and users had no control over whether to show unread counts.

Screenshots and screen captures:
image
企业微信截图_2407321c-29eb-469a-8fc2-1c5808a90075

[You should add screenshots showing the tray icon before/after changes and the new toggle setting]

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (specify distro)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

timabbott
timabbott reviewed Jun 18, 2025
View reviewed changes
@timabbott
Copy link
Member

timabbott commented Jun 18, 2025

Thanks for the PR @Weiged! Can you clean up the commit history in addition to dropping the (I assume AI-generated) translations? Check out our GitHub guide and commit guidelines for more details.

@Weiged Weiged force-pushed the main branch 2 times, most recently from cc7608e to fa2fc00 Compare June 18, 2025 03:33
@zulipbot zulipbot added size: L and removed size: XL labels Jun 18, 2025
@DaZhu233
tray: Add unread count badge option for macOS tray icon
92ef088 
Add a new configuration option 'trayBadgeCount' that allows users to
display unread message count on the tray icon for macOS. When enabled,
the tray icon shows the unread count as a title badge instead of
modifying the icon image itself.

This change:
- Adds trayBadgeCount configuration option to config schema
- Adds toggle-tray-badge-count IPC message for preference updates
- Implements displayTrayIcon() function to handle platform-specific
  tray icon display logic
- Updates preference UI to show the option only on macOS
- Refactors tray logic to use consistent display methods across platforms

The feature is macOS-specific because other platforms already use
icon overlays to show unread counts, while macOS can use the cleaner
title badge approach.
@Weiged
Copy link
Author

Weiged commented Jun 20, 2025

@timabbott all done

@timabbott
Copy link
Member

timabbott commented Jun 25, 2025

@shubham-padia can you review this one?

@Weiged
Copy link
Author

Weiged commented Aug 7, 2025

@shubham-padia hello?

@Weiged
Copy link
Author

Weiged commented Aug 11, 2025

@timabbott shubham-padia seems too busy

@shubham-padia
Copy link
Member

shubham-padia commented Oct 24, 2025

Sorry for the late response. I'm not sure why we need this, opened a discussion at: #desktop > #D1429 Add toggle setting for Mac tray icon unread count @ 💬

@Weiged Weiged closed this Oct 24, 2025
@timabbott
Copy link
Member

timabbott commented Oct 27, 2025

@Weiged can you talk about why you wanted this? We had not made a determination that this was not useful -- just wanted to hear an explanation of how it would be used.

@timabbott timabbott reopened this Oct 27, 2025
@Weiged
Copy link
Author

Weiged commented Oct 31, 2025

@Weiged can you talk about why you wanted this? We had not made a determination that this was not useful -- just wanted to hear an explanation of how it would be used.

Someone like me always set dock auto hide. So unread notify on application icon is invisible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timabbott timabbott timabbott left review comments

Assignees

No one assigned

Labels

size: L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Weiged @timabbott @shubham-padia @zulipbot @DaZhu233