link_utils: exposing whitelisted protocols to user settings #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zulip#1284. Adding config option to set protocols in the config that are whitelisted to be opened directly. The behaviour is documented in docs\howto\customize-link-protocols.md.
2 tasks
alya
reviewed
Nov 10, 2025
| @@ -0,0 +1,35 @@ | |||
| # Customizing Link Protocols | |||
Collaborator
There was a problem hiding this comment.
We should be using standard Zulip capitalization throughout (sentence case).
alya
reviewed
Nov 10, 2025
| } | ||
| ``` | ||
|
|
||
| Note: Each protocol should include the trailing colon (:), e.g., "mailto:" instead of "mailto". |
Collaborator
There was a problem hiding this comment.
Suggested change
| Note: Each protocol should include the trailing colon (:), e.g., "mailto:" instead of "mailto". | |
| Note: Each protocol should include the trailing `:`, e.g., "mailto:" instead of "mailto". |
Collaborator
|
@andersk Tagging for your review. |
andersk
reviewed
Nov 12, 2025
Comment on lines
+10
to
+16
| const whitelistedProtocols = ConfigUtil.getConfigItem("whitelistedProtocols", [ | ||
| "http:", | ||
| "https:", | ||
| "mailto:", | ||
| "tel:", | ||
| "sip:", | ||
| ]); |
Member
There was a problem hiding this comment.
getConfigItem writes the default value into the config file if it’s missing, so if we ever add new default protocols they’ll never be visible to someone who’s ever launched an old version.
(Was this a bad design decision for getConfigItem? Yes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1284.
Adding config option to set protocols in the config that are whitelisted to be opened directly.
The behaviour is documented in docs\howto\customize-link-protocols.md.
Supersedes #1401. Keeps the original author same.
Fixes:
Screenshots and screen captures:
Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: