Skip to content

style: Set correct dark-theme message background color #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loveucifer
Copy link

Fixes #1685.

The DesignVariables.bgMessageRegular color was slightly incorrect in dark mode. The previous value, const HSLColor.fromAHSL(1, 0, 0, 0.11).toColor(), resulted in a background color of #1C1C1C, which created a noticeable contrast with the main background. This value might have been a legacy from a previous design iteration.

The Figma design clearly specifies #1D1D1D for the bg-message-regular variable in dark mode. This change updates the value to match the design specification, ensuring a consistent and uniform background for messages.

Before
unnamed-2

After
unnamed

@gnprice
Copy link
Member

gnprice commented Jul 18, 2025

Thanks. Can you post a pair of screenshots that are as similar as possible except for your change? With the current screenshots it's difficult to tell what's caused by your change, because all the content in the screenshots is different.

Using Flutter's hot reload:
https://docs.flutter.dev/tools/hot-reload
it should be possible to switch quickly back and forth between the "before" and "after" versions of the code, without leaving your place in the running app. That should make it possible to get pretty much the exact same shot in both "before" and "after".

@gnprice
Copy link
Member

gnprice commented Jul 18, 2025

For the backstory in the description, see the comment I just posted on the issue: #1685 (comment)

@gnprice
Copy link
Member

gnprice commented Jul 18, 2025

These before/after screenshots would also benefit from going into a table. See Zulip's contributor docs here:
https://zulip.readthedocs.io/en/latest/contributing/reviewable-prs.html#demonstrating-visual-changes

@loveucifer
Copy link
Author

thanks , I hope this solve it
before
BEFORE
after
AFTER

@loveucifer
Copy link
Author

I Also had some doubts on the assigned tasks , i saw some of them that were labelled beginner friendly were assigned to someone else , so am i not allowed to work on it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DesignVariables.bgMessageRegular is slightly wrong in dark mode
2 participants