content: Relax image-preview parsing, notably to accept arbitrary CAMO_URI #1933
+42
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Oct 23, 2025
rajveermalviya
added
integration review
…review This kind of URL is already covered in the tests of *clusters* of image previews, but it seems helpful to isolate it like this with its own comment. We're also about to add a third variant, testing that we accept images generated with an arbitrary CAMO_URI, which actually we don't currently do, so that'll be a regression test.
…O_URI See discussion: https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/documenting.20inline.20images/near/2279454 We already test the `src == href` case, as ContentExample.imagePreviewSingleNoThumbnail, but I added a test case for an arbitrary CAMO_URI that fails before this commit.
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-arbitrary-camo-url
branch
from
27cc8ed to
0c7edc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion:
https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/documenting.20inline.20images/near/2279454