Skip to content

Conversation

@rajveermalviya
Copy link
Member

This commit is the result of the following commands:
  flutter pub upgrade --major-versions firebase_messaging firebase_core
  tools/upgrade pod

Changelogs:
  https://pub.dev/packages/firebase_core/changelog#420
  https://pub.dev/packages/firebase_messaging/changelog#1603

Notable changes include bump to Firebase Android BoM (34.1.0 to 34.4.0)
and Firebase iOS SDK (12.2.0 to 12.4.0), changelog for those are at:
  https://firebase.google.com/support/release-notes/android
  https://firebase.google.com/support/release-notes/ios

For Android SDK, no notable changes in the FCM component.

For iOS SDK, no changes in the FCM component.
This commit is the result of the following commands:
  flutter pub upgrade --major-versions pigeon
  tools/check --all-files --fix pigeon

Changelog:
  https://pub.dev/packages/pigeon/changelog#2602

There is one change related `@ProxyApi` which we do not use,
and one about improvements to logging errors.
This commit is the result of the following commands:
  flutter pub upgrade --major-versions drift drift_dev
  tools/check --all-files --fix drift

Changelog:
  https://pub.dev/packages/drift/changelog#2290
  https://pub.dev/packages/drift_dev/changelog#2290
@rajveermalviya rajveermalviya added the maintainer review PR ready for review by Zulip maintainers label Oct 21, 2025
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Can you explain more the motivation for the last two commits?
53577d7 zulip plugin: Use flutter.compileSdkVersion for compileSdk
c7fbd6e zulip plugin: Switch to compilerOptions from kotlinOptions

(E.g., does something go wrong without them?)

Otherwise, these changes all LGTM.

@rajveermalviya
Copy link
Member Author

does something go wrong without them?

No nothing goes wrong, just some cleanup and trying to match our android/app/build.gradle for the app.

@gnprice
Copy link
Member

gnprice commented Oct 22, 2025

Ah OK, makes sense. Please explain that in the commit messages, then :-) — that's the readable permanent record of why we did things.

@rajveermalviya
Copy link
Member Author

Thanks for the review @gnprice! Pushed an update, PTAL.

@chrisbobbe
Copy link
Collaborator

Thanks! LGTM, and looks good in manual testing on an iOS simulator. Marking for Greg's review.

@chrisbobbe chrisbobbe assigned gnprice and unassigned chrisbobbe Oct 23, 2025
@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Oct 23, 2025
To match our `android/app/build.gradle`, and it is similar to a
change earlier this year for Flutter's first-party plugins:
  flutter/packages@bfad6b976
This is related to zulip#1804, and does the same migration for zulip_plugin.
@gnprice
Copy link
Member

gnprice commented Oct 24, 2025

Thanks @rajveermalviya for the revision, and @chrisbobbe for testing this! Merging, with two nits fixed:

     To match our `android/app/build.gradle`, and it is similar to a
-    change that happened for Flutter's first-party plugins:
-      flutter/packages@bfad6b9
+    change earlier this year for Flutter's first-party plugins:
+      flutter/packages@bfad6b976

Use at least 9 hex digits (vs. just 7) to mention a commit ID:
https://github.com/zulip/zulip-mobile/blob/main/docs/style.md#mentioning-commits

7 hex digits, which is what GitHub shows in its UI whenever it doesn't show 40, is short enough that there's a material risk of collisions: in zulip.git there are already a handful of commits that are ambiguous when identified by just 7 digits, and in a very large project like the Linux kernel such collisions can become routine.

-    zulip plugin: Use flutter.compileSdkVersion for compileSdk
+    zulip_plugin: Use flutter.compileSdkVersion for compileSdk

-    zulip plugin: Switch to compilerOptions from kotlinOptions
+    zulip_plugin: Switch to compilerOptions from kotlinOptions

I think the phrase "Zulip plugin" isn't particularly self-explanatory for what this subtree does, so the identifier zulip_plugin is a clearer way to refer to it.

(It looks like these are the first commits touching this subtree since it was introduced in 058f184, so this is basically the first time we're picking a commit-message prefix to use for it.)

@gnprice gnprice force-pushed the pr-flutter-upgrade branch from 8561219 to 2f1dcc9 Compare October 24, 2025 01:32
@gnprice gnprice merged commit 2f1dcc9 into zulip:main Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Images repeatedly re-fetched on Android HEIF images from selfie cam are shown upside down

3 participants