-
Notifications
You must be signed in to change notification settings - Fork 344
Upgrade Flutter and packages #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit is the result of the following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core tools/upgrade pod Changelogs: https://pub.dev/packages/firebase_core/changelog#420 https://pub.dev/packages/firebase_messaging/changelog#1603 Notable changes include bump to Firebase Android BoM (34.1.0 to 34.4.0) and Firebase iOS SDK (12.2.0 to 12.4.0), changelog for those are at: https://firebase.google.com/support/release-notes/android https://firebase.google.com/support/release-notes/ios For Android SDK, no notable changes in the FCM component. For iOS SDK, no changes in the FCM component.
This commit is the result of the following commands: flutter pub upgrade --major-versions pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2602 There is one change related `@ProxyApi` which we do not use, and one about improvements to logging errors.
This commit is the result of the following commands: flutter pub upgrade --major-versions drift drift_dev tools/check --all-files --fix drift Changelog: https://pub.dev/packages/drift/changelog#2290 https://pub.dev/packages/drift_dev/changelog#2290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Can you explain more the motivation for the last two commits?
53577d7 zulip plugin: Use flutter.compileSdkVersion for compileSdk
c7fbd6e zulip plugin: Switch to compilerOptions from kotlinOptions
(E.g., does something go wrong without them?)
Otherwise, these changes all LGTM.
No nothing goes wrong, just some cleanup and trying to match our
|
|
Ah OK, makes sense. Please explain that in the commit messages, then :-) — that's the readable permanent record of why we did things. |
c7fbd6e to
8561219
Compare
|
Thanks for the review @gnprice! Pushed an update, PTAL. |
|
Thanks! LGTM, and looks good in manual testing on an iOS simulator. Marking for Greg's review. |
To match our `android/app/build.gradle`, and it is similar to a change earlier this year for Flutter's first-party plugins: flutter/packages@bfad6b976
This is related to zulip#1804, and does the same migration for zulip_plugin.
|
Thanks @rajveermalviya for the revision, and @chrisbobbe for testing this! Merging, with two nits fixed: Use at least 9 hex digits (vs. just 7) to mention a commit ID:
I think the phrase "Zulip plugin" isn't particularly self-explanatory for what this subtree does, so the identifier (It looks like these are the first commits touching this subtree since it was introduced in 058f184, so this is basically the first time we're picking a commit-message prefix to use for it.) |
8561219 to
2f1dcc9
Compare
Flutter notable commits
Fixes: #1785
Fixes: #1892