content: Show image/video previews larger according to realm setting#2202
Draft
MritunjayTiwari14 wants to merge 7 commits intozulip:mainfrom
Draft
content: Show image/video previews larger according to realm setting#2202MritunjayTiwari14 wants to merge 7 commits intozulip:mainfrom
MritunjayTiwari14 wants to merge 7 commits intozulip:mainfrom
Conversation
MritunjayTiwari14
changed the title
MritunjayTiwari14
force-pushed
the
image_resizing
branch
from
f86d4bc to
309f4a3
Compare
MritunjayTiwari14
force-pushed
the
image_resizing
branch
from
309f4a3 to
a65678b
Compare
Since it is supported from FL-468 (server-12), the enum also accepts null values as a fallback to default size. Fixes 2 todo's: Changed int? to enum type of botType in `User.botType` Added server-11 to `localeDefault` value of `TwentyFourHourTimeMode` enum.
This would allow us to handle RealmEvent with different op values. relevant docs: https://chat.zulip.org/api/get-events#realm
This would allow us to update `realmMediaPreviewSize` since this is part of realm with op:update_dict event whenever we would recieve an event for it. relevant docs: https://chat.zulip.org/api/get-events#realm-update_dict
MritunjayTiwari14
force-pushed
the
image_resizing
branch
from
a65678b to
f2bae28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2177.
Partially, Fixes #668.