msglist: Update message list on muting/unmuting a channel - #2423
Open
chrisbobbe wants to merge 3 commits into
Open
msglist: Update message list on muting/unmuting a channel#2423chrisbobbe wants to merge 3 commits into
chrisbobbe wants to merge 3 commits into
Conversation
This type describes an effect on the results of isTopicVisible and isTopicVisibleInChannel. Currently those effects only come from user_topic events, but soon (for zulip#1255) a channel mute or unmute will have the same kind of effect. Name the type after those methods, rather than after the events that cause the effects. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Soon (for zulip#1255) an event other than a user_topic event -- namely a subscription-update event for a channel's mutedness -- will also be able to affect the results of isTopicVisible. Rather than add a separate method with an unwieldy name for that cause, prepare this method to take any kind of event, answering "none" for the kinds that don't affect the results. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes zulip#1255. When a channel is muted, remove its newly-hidden messages from any combined-feed message list; when unmuted, refetch from scratch, the same way we handle a topic getting unmuted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1255.
When a channel is muted, remove its newly-hidden messages from any combined-feed message list; when unmuted, refetch from scratch, the same way we handle a topic getting unmuted.
(Prompted by wanting to demo some Zulip development in person at the Recurse Center—I'll likely follow this soon with a PR to add a mute/unmute-channel button in the channel action sheet, #347.)