log [nfc]: Stop depending on Flutter for build-mode constants - #2432
Open
chrisbobbe wants to merge 1 commit into
Open
log [nfc]: Stop depending on Flutter for build-mode constants#2432chrisbobbe wants to merge 1 commit into
chrisbobbe wants to merge 1 commit into
Conversation
Flutter defines kReleaseMode and friends very simply, from compile-time environment flags of the Dart VM; so copy those definitions into lib/basic.dart. This means lib/log.dart no longer needs Flutter, which helps toward making lib/api usable from the plain Dart VM (zulip#2335): lib/api imports lib/log.dart for debugLog. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #2335.