views/keys/hotkeys: Add key to copy message content #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a key to copy message content which can be then pasted. Implemented using preexisting `copy_to_clipboard` function Fixes zulip#546
zulipbot
added
size: M
|
@zulipbot add "PR needs review" |
neiljp
reviewed
Apr 18, 2023
Comment on lines
+1685
to
+1695
| elif is_command_key("COPY_MESSAGE", key): | ||
| rendered_content, *_ = MessageBox.transform_content( | ||
| self.msg["content"], self.controller.model.server_url | ||
| ) | ||
| content = [] | ||
| for word in rendered_content[1]: | ||
| if isinstance(word, tuple): # if msg content has markup | ||
| content.append(word[1]) | ||
| else: | ||
| content.append(word) | ||
| self.controller.copy_to_clipboard("".join(content), "Message Content") |
There was a problem hiding this comment.
The principle here is just fine, but we do perform a few extra adjustments to content which may not follow the principles that you assume here.
That's likely what gave rise to the crash I reported in the stream.
Comment on lines
+399
to
+403
| ('COPY_MESSAGE', { | ||
| 'keys': ['C'], | ||
| 'help_text': | ||
| 'Copy message content to clipboard', | ||
| 'key_category': 'msg_actions', |
There was a problem hiding this comment.
We've discussed this in the stream, but
cshould not need capitalization, with some adjustment, if we stick with that hotkey, though key choice right now is not important- though note that we already have
cfor copying stream email address - plus we discussed something similar for the copy non-markdown content version
- though note that we already have
- the help_text likely doesn't need to wrap? That's only been done for long lines
- we may want the COPY_MESSAGE to be more meaningful if we have two versions :)
neiljp
added
PR awaiting update
|
Heads up @Sushmey, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
Copying a message using terminal selection does not work across multiple lines, as it also selects text in one or both of the side bars.
It would be useful to be able to copy selected message(s) independently of how the UI is set up.
This could be for quoting in another stream, or external to ZT.
Adding a key to copy message content which can be then pasted. Implemented using preexisting
copy_to_clipboardfunction.Outstanding aspect(s)
This seems to not work for quotes messages because of the nested list
Unsure as to how to navigate about specific cases like
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes