Skip to content

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Jun 15, 2023

What does this PR do, and why?

WIP

Outstanding aspect(s)

  • [ ]

External discussion & connections

  • Discussed in #zulip-terminal in topic
  • Fully fixes #
  • Partially fixes issue #
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • Merge will enable work on #

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

Visual changes

@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label Jun 15, 2023
@neiljp neiljp force-pushed the 2023-06-14-windows-ci-test branch from 4c725d7 to 06852c5 Compare June 15, 2023 05:28
@zulipbot zulipbot added size: S [Automatic label added by zulipbot] and removed size: XS [Automatic label added by zulipbot] labels Jun 15, 2023
@neiljp neiljp force-pushed the 2023-06-14-windows-ci-test branch 4 times, most recently from c3d4749 to d5b367d Compare June 15, 2023 07:17
@neiljp neiljp force-pushed the 2023-06-14-windows-ci-test branch from d5b367d to 06ef285 Compare May 12, 2024 19:22
@zulipbot zulipbot added size: L [Automatic label added by zulipbot] and removed size: S [Automatic label added by zulipbot] has conflicts labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants