Extend platform detection to include details of python #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extracts the mocking to occur automatically given a platform string, and provide the expected output text, which is tested in various tests.
Tests and fixture updated.
neiljp
force-pushed
the
2023-10-24-python-version-detection
branch
3 times, most recently
from
067c461 to
a27e393
Compare
Using '3.x' automatically selected a high single version of python on MacOS. However, it bumped the python version over the version that we support, breaking with no warning - and also using different python versions between PRs. This could be useful to have with a manual trigger, or if it did not break regular builds. This is an effective revert of d8bae88.
Note that a side-effect of the change to use a specific python version on MacOS in a recent commit is that this platform does not need to be excluded manually.
This includes the established Platform (PLATFORM), and the recent addition of the python version and implementation. Test updated.
neiljp
force-pushed
the
2023-10-24-python-version-detection
branch
from
6c5378a to
e10b610
Compare
zulipbot
added
size: XL
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This was motivated by confirming which python was being used for running ZT, originally in the context of testing locally with python 3.12 and others (eg. for #1379).
Having this information included is also useful to users, as well as for having feedback from them. Initial console output is therefore updated to show this, and included in the About popup in a new Detected Environment category, including the platform - which resolves the last part of #1216.
In much the same way as the detected platform, a test step is also added to CI to ensure that the expected python version matches that detected.
Note that this includes the platform (CPython vs PyPy), and if present the branch - which appears to be where the PyPy implementation version is stored.
This also includes an infrastructure simplification to avoid MacOS testing on 3.x, which was a simple way to test on the latest version, but randomly breaks CI if version support is not updated - and would require a special case for python environment detection.
Outstanding aspect(s)
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes