feat: add column sort on Node View pods table, close #271 #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
How do you think about using this component directly? https://github.com/zxh326/kite/blob/main/ui/src/components/resource-table-view.tsx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds column sorting functionality to the Node View pods table by refactoring
PodTableto use TanStack Table, matching the same implementation strategy used in the Pod view.Changes
PodTableto use TanStack Table (useReactTable)createColumnHelperpattern consistent withPodListPageTesting
Tested locally with k3d cluster - sorting works correctly for all columns, matching the Pod view experience.
Closes #271