Skip to content

PHP: Well deprecate lizmapRepository class #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

PHP: Well deprecate lizmapRepository class #5917

wants to merge 4 commits into from

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Jul 6, 2025

  • The lizmapRepository class now extends \Lizmap\Project\Repository.
  • Replace lizmapRepository static properties usage by Repository static properties

@rldhont rldhont added php Pull requests that update Php code backport release_3_10 labels Jul 6, 2025
@github-actions github-actions bot added this to the 3.11.0 milestone Jul 6, 2025
@rldhont rldhont force-pushed the php-lizmaprepository-deprecation branch 4 times, most recently from de55162 to 938da35 Compare July 7, 2025 06:22
@rldhont rldhont requested review from Gustry and laurentj July 7, 2025 06:23
@laurentj
Copy link
Collaborator

laurentj commented Jul 7, 2025

Why don't you remove the class? It has been deprecated since 2021.

@Gustry Gustry mentioned this pull request Jul 8, 2025
Open
@rldhont
Copy link
Collaborator Author

rldhont commented Jul 8, 2025

Why don't you remove the class? It has been deprecated since 2021.

Because lizmap::getRepository returned lizmapRepository instead of \Lizmap\Project\Repository and because I saw it in a deprecated Jelix class.

But I can remove this class.

@rldhont rldhont force-pushed the php-lizmaprepository-deprecation branch from 938da35 to 3804339 Compare July 31, 2025 15:31
@rldhont rldhont force-pushed the php-lizmaprepository-deprecation branch 2 times, most recently from 5f1fe36 to c8c90d7 Compare August 28, 2025 11:59
@rldhont rldhont force-pushed the php-lizmaprepository-deprecation branch from c8c90d7 to 6a526b8 Compare August 28, 2025 17:53
@Gustry Gustry removed their request for review September 10, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentj laurentj Awaiting requested review from laurentj

Assignees
No one assigned
Labels
backport release_3_10 php Pull requests that update Php code
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rldhont @laurentj