Increase the number of CPU nodes in the Pathways CPU nodepool. #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoshaniN
requested review from
Obliviour,
44past4,
sharabiani,
pawloch00,
BluValor and
gcie
as code owners
RoshaniN
added
enhancement
RoshaniN
force-pushed
the
increase_nodepools
branch
from
2edb313 to
f9fefa6
Compare
RoshaniN
force-pushed
the
increase_nodepools
branch
from
f9fefa6 to
eac6490
Compare
pawloch00
approved these changes
May 29, 2025
sharabiani
reviewed
May 29, 2025
| f' --machine-type={args.pathways_gce_machine_type} --scopes=storage-full,gke-default,{CLOUD_PLATFORM_AUTH_SCOPE_URL} --enable-autoscaling' | ||
| ' --min-nodes=1 --max-nodes=20' | ||
| ) | ||
| # Resize Pathways CPU nodepool to have at least 4 nodes |
There was a problem hiding this comment.
LGTM, however I believe it will downsize a node-pool if the number of nodes are already bigger than 4 nodes.
|
@RoshaniN is this going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
This feature only affects Pathways enabled clusters.
Testing / Documentation
Tested on a cluster with 19 v5litepod-32