Skip to content

Increase the number of CPU nodes in the Pathways CPU nodepool. #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Increase the number of CPU nodes in the Pathways CPU nodepool. #481

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eac6490
Increase the number of CPU nodes in the Pathways CPU nodepool.
RoshaniN May 28, 2025
8249465
Merge branch 'develop' into increase_nodepools
pawloch00 Jul 9, 2025
e3696df
Merge branch 'develop' into increase_nodepools
pawloch00 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/xpk/core/nodepool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,20 @@ def run_gke_node_pool_create_command(
# Pathways needs CPU nodepools in addition to TPU nodepools
for node_pool_name in desired_pw_cpu_node_pools:
if node_pool_name in existing_node_pool_names:
continue
command = (
'gcloud beta container node-pools create'
f' {node_pool_name} --node-version={gke_node_pool_version} --cluster={args.cluster} --project={args.project} --node-locations={args.zone} --region={zone_to_region(args.zone)} --num-nodes=1'
f' --machine-type={args.pathways_gce_machine_type} --scopes=storage-full,gke-default,{CLOUD_PLATFORM_AUTH_SCOPE_URL} --enable-autoscaling'
' --min-nodes=1 --max-nodes=20'
)
# Resize Pathways CPU nodepool to have at least 4 nodes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I believe it will downsize a node-pool if the number of nodes are already bigger than 4 nodes.

command = (
'gcloud container clusters resize'
f' {args.cluster} --project={args.project} --node-pool'
f' {node_pool_name} --num-nodes=4'
f' --region={zone_to_region(args.zone)} --quiet'
)
else:
command = (
'gcloud beta container node-pools create'
f' {node_pool_name} --node-version={gke_node_pool_version} --cluster={args.cluster} --project={args.project} --node-locations={args.zone} --region={zone_to_region(args.zone)} --num-nodes=4'
f' --machine-type={args.pathways_gce_machine_type} --scopes=storage-full,gke-default,{CLOUD_PLATFORM_AUTH_SCOPE_URL} --enable-autoscaling'
' --min-nodes=1 --max-nodes=20'
)
task = f'NodepoolCreate-{node_pool_name}'
create_commands.append(command)
create_task_names.append(task)
Expand Down
Loading