[Monitor] Add TypeSpec-based azure-monitor-querymetrics package #42174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the TypeSpec-based azure-monitor-querymetrics package. Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
changed the title
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
monitor-querymetrics-typespec-patch
branch
from
bd816dd to
c6c52c0
Compare
Signed-off-by: Paul Van Eck <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
requested review from
msyyc,
lmazuel,
scbedd,
mccoyp,
benbp,
weshaggard and
lirenhe
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the TypeSpec-based azure-monitor-querymetrics package to the Azure SDK for Python without using a _generated sub-directory structure. The package provides metrics querying capabilities for Azure Monitor resources across multiple regions.
Key changes include:
- Implementation of sync and async MetricsClient with TypeSpec-generated models
- Custom client patches that provide high-level query_resources methods
- Comprehensive test suite with authentication, granularity, and filtering tests
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/ci.yml | Adds package to CI configuration |
| sdk/monitor/azure-monitor-querymetrics/tsp-location.yaml | TypeSpec source configuration |
| sdk/monitor/azure-monitor-querymetrics/setup.py | Package setup and dependencies |
| sdk/monitor/azure-monitor-querymetrics/tests/ | Test files for sync/async clients |
| sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/ | Core package implementation with models, clients, and utilities |
sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/aio/_patch.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-querymetrics/azure/monitor/querymetrics/_patch.py
Show resolved
Hide resolved
lmazuel
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the TypeSpec-based
azure-monitor-querymetricspackage without using a_generatedsub-directory.