-
Notifications
You must be signed in to change notification settings - Fork 3
Removing container build cacheing to assess build reliability without it #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
- Coverage 26.21% 26.18% -0.04%
==========================================
Files 26 26
Lines 2411 2414 +3
==========================================
Hits 632 632
- Misses 1779 1782 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dylanhmorris not sure what's going on with the format-suggest check, but otherwise, I removed the cacheing code and the container successfully builds and post to ghcr.io. Let me know if there's a way I can help test the functionality of the container, or if that's even necessary given our automated tests. If not necessary, please feel free to review or provide feedback! Thanks, |
Thanks, @jkislin! I think the best way to test functionality before merging to try running a job in Azure with the |
I am still getting a Manifest unknown error. I will investigate more tomorrow. |
|
@jkislin I think with these simplifications we can just remove the Might resolve the manifest issues and should in general be more robust |
…nto jk-rm-cache

Running tests. Will request review. It probably makes sense to leave the cache code commented in the script as we may change our mind again!