Skip to content

Removing container build cacheing to assess build reliability without it #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Removing container build cacheing to assess build reliability without it #659

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a88b93
commented out cache code in docker_build_and_push.sh
jkislin Sep 4, 2025
aab4680
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 4, 2025
2ccca33
Merge branch 'main' of https://github.com/CDCgov/pyrenew-hew into jk-…
jkislin Sep 15, 2025
71a098a
Merge branch 'main' into jk-rm-cache
jkislin Sep 15, 2025
59f4059
Merge branch 'jk-rm-cache' of https://github.com/CDCgov/pyrenew-hew i…
jkislin Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/scripts/docker_build_and_push.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,19 @@ BUILDER=docker-container-driver-builder
docker buildx create --name "$BUILDER" --driver=docker-container || true

# use the registry cache for prior images of the same tag, or the 'latest' tag
# time docker buildx build --push -t "$IMAGE:$TAG" \
# --builder "$BUILDER" \
# --build-arg "GIT_COMMIT_SHA=$GIT_COMMIT_SHA" \
# --build-arg "GIT_BRANCH_NAME=$GIT_BRANCH_NAME" \
# --cache-from "type=registry,ref=$IMAGE:$TAG-cache" \
# --cache-from "type=registry,ref=$IMAGE:latest-cache" \
# --cache-to "type=registry,ref=$IMAGE:$TAG-cache,mode=max" \
# -f Containerfile .

# attempt without registry cache - we care less about speed
# and more about deterministic rebuilds
time docker buildx build --push -t "$IMAGE:$TAG" \
--builder "$BUILDER" \
--build-arg "GIT_COMMIT_SHA=$GIT_COMMIT_SHA" \
--build-arg "GIT_BRANCH_NAME=$GIT_BRANCH_NAME" \
--cache-from "type=registry,ref=$IMAGE:$TAG-cache" \
--cache-from "type=registry,ref=$IMAGE:latest-cache" \
--cache-to "type=registry,ref=$IMAGE:$TAG-cache,mode=max" \
-f Containerfile .